Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

From: Chunhao Lin Date: Tue, 8 Mar 2016 16:51:05 +0800 > For pcie nic, after setting link speed and thers is no link driver does not > need > to do phy reset untill link up. "there's", "until" > For some pcie nics, to do this will also reset phy speed down counter and >

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

From: Chunhao Lin Date: Tue, 8 Mar 2016 16:51:05 +0800 > For pcie nic, after setting link speed and thers is no link driver does not > need > to do phy reset untill link up. "there's", "until" > For some pcie nics, to do this will also reset phy speed down counter and > prevent > phy from

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

Hau : [...] > Unless pcie nic has bug, pcie nic does not need to reset phy to let phy link > on. > > There is a counter for phy speed down. If phy is in link down state, this > counter will start to count down. When it count to 0, phy will speed down. > Reset phy will reset

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

Hau : [...] > Unless pcie nic has bug, pcie nic does not need to reset phy to let phy link > on. > > There is a counter for phy speed down. If phy is in link down state, this > counter will start to count down. When it count to 0, phy will speed down. > Reset phy will reset this counter and

RE: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

[...] > Can you clarify: > - actually this patch does not care about the link at all. So when there's > link no phy reset is needed either, right ? > - does "this" in "to do this" means that > 1. phy reset prevents phy from auto speed down > 2. avoiding phy reset prevents phy from auto

RE: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

[...] > Can you clarify: > - actually this patch does not care about the link at all. So when there's > link no phy reset is needed either, right ? > - does "this" in "to do this" means that > 1. phy reset prevents phy from auto speed down > 2. avoiding phy reset prevents phy from auto

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

Chunhao Lin : > For pcie nic, after setting link speed and thers is no link driver does not > need > to do phy reset untill link up. > > For some pcie nics, to do this will also reset phy speed down counter and > prevent > phy from auto speed down. > > This patch fix the

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

Chunhao Lin : > For pcie nic, after setting link speed and thers is no link driver does not > need > to do phy reset untill link up. > > For some pcie nics, to do this will also reset phy speed down counter and > prevent > phy from auto speed down. > > This patch fix the issue reported in