Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-10 Thread Paraschiv, Andra-Irina
On 09/12/2020 19:30, Jakub Kicinski wrote: On Wed, 9 Dec 2020 17:17:56 +0200 Paraschiv, Andra-Irina wrote: I agree that could be a problem, but here some considerations: - I checked some applications (qemu-guest-agent, ncat, iperf-vsock) and all use the same pattern: allocate memory,

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 17:17:56 +0200 Paraschiv, Andra-Irina wrote: > > I agree that could be a problem, but here some considerations: > > - I checked some applications (qemu-guest-agent, ncat, iperf-vsock) and > >   all use the same pattern: allocate memory, initialize all the > >   sockaddr_vm to

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-09 Thread Paraschiv, Andra-Irina
On 09/12/2020 12:48, Stefano Garzarella wrote: On Tue, Dec 08, 2020 at 10:42:22AM -0800, Jakub Kicinski wrote: On Tue, 8 Dec 2020 20:23:24 +0200 Paraschiv, Andra-Irina wrote: >> --- a/include/uapi/linux/vm_sockets.h >> +++ b/include/uapi/linux/vm_sockets.h >> @@ -145,7 +145,7 @@ >> >>  

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-09 Thread Stefano Garzarella
On Tue, Dec 08, 2020 at 10:42:22AM -0800, Jakub Kicinski wrote: On Tue, 8 Dec 2020 20:23:24 +0200 Paraschiv, Andra-Irina wrote: >> --- a/include/uapi/linux/vm_sockets.h >> +++ b/include/uapi/linux/vm_sockets.h >> @@ -145,7 +145,7 @@ >> >> struct sockaddr_vm { >>__kernel_sa_family_t

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 20:23:24 +0200 Paraschiv, Andra-Irina wrote: > >> --- a/include/uapi/linux/vm_sockets.h > >> +++ b/include/uapi/linux/vm_sockets.h > >> @@ -145,7 +145,7 @@ > >> > >> struct sockaddr_vm { > >>__kernel_sa_family_t svm_family; > >> - unsigned short svm_reserved1; > >>

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-08 Thread Paraschiv, Andra-Irina
On 07/12/2020 23:29, Jakub Kicinski wrote: On Fri, 4 Dec 2020 19:02:32 +0200 Andra Paraschiv wrote: diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h index fd0ed7221645d..46735376a57a8 100644 --- a/include/uapi/linux/vm_sockets.h +++

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 19:02:32 +0200 Andra Paraschiv wrote: > diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h > index fd0ed7221645d..46735376a57a8 100644 > --- a/include/uapi/linux/vm_sockets.h > +++ b/include/uapi/linux/vm_sockets.h > @@ -145,7 +145,7 @@ > > struct

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-07 Thread Paraschiv, Andra-Irina
On 07/12/2020 11:59, Stefano Garzarella wrote: On Fri, Dec 04, 2020 at 07:02:32PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transport support (guest->host and host->guest), nested VMs can also use vsock

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-07 Thread Stefano Garzarella
On Fri, Dec 04, 2020 at 07:02:32PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transport support (guest->host and host->guest), nested VMs can also use vsock channels for communication. In addition to this,