RE: [PATCH net-next v3 8/9] xen-netback: Timeout packets in RX path

2014-01-13 Thread Paul Durrant
> -Original Message- > From: Zoltan Kiss > Sent: 13 January 2014 00:20 > To: Paul Durrant; Ian Campbell; Wei Liu; xen-de...@lists.xenproject.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jonathan Davies > Subject: Re: [PATCH net-next v3 8/9] xen-netback:

Re: [PATCH net-next v3 8/9] xen-netback: Timeout packets in RX path

2014-01-12 Thread Zoltan Kiss
On 09/01/14 09:20, Paul Durrant wrote: We are adding the skb to vif->rx_queue even when xenvif_rx_ring_slots_available(vif, min_slots_needed) said there is no space for that. Or am I missing something? Paul? That's correct. Part of the flow control improvement was to get rid of needless packet

RE: [PATCH net-next v3 8/9] xen-netback: Timeout packets in RX path

2014-01-09 Thread Paul Durrant
> -Original Message- > From: Zoltan Kiss > Sent: 08 January 2014 21:34 > To: Ian Campbell; Wei Liu; xen-de...@lists.xenproject.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Jonathan Davies > Cc: Zoltan Kiss; Paul Durrant > Subject: Re: [PATCH net-nex

Re: [PATCH net-next v3 8/9] xen-netback: Timeout packets in RX path

2014-01-08 Thread Zoltan Kiss
I just realized when answering Ma's mail that this doesn't cause the desired effect after Paul's flow control improvement: starting the queue doesn't drop the packets which cannot fit the ring. Which in fact might be not good. We are adding the skb to vif->rx_queue even when xenvif_rx_ring_slot