Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-23 Thread Helge Deller
On 2/23/21 3:23 PM, Petr Mladek wrote: On Tue 2021-02-23 13:22:22, Helge Deller wrote: On 2/22/21 5:28 PM, Petr Mladek wrote: On Sun 2021-02-21 22:39:42, Helge Deller wrote: On 2/19/21 5:33 PM, John Ogness wrote: Added CC: linux-par...@vger.kernel.org On 2021-02-19, John Ogness wrote:

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-23 Thread Petr Mladek
On Mon 2021-02-22 17:43:56, John Ogness wrote: > On 2021-02-22, Petr Mladek wrote: > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 20c21a25143d..401df370832b 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > +/* Return a

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-23 Thread Petr Mladek
On Tue 2021-02-23 13:22:22, Helge Deller wrote: > On 2/22/21 5:28 PM, Petr Mladek wrote: > > On Sun 2021-02-21 22:39:42, Helge Deller wrote: > > > On 2/19/21 5:33 PM, John Ogness wrote: > > > > Added CC: linux-par...@vger.kernel.org > > > > > > > > On 2021-02-19, John Ogness wrote: > > > > > > >

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-23 Thread Helge Deller
On 2/22/21 5:28 PM, Petr Mladek wrote: On Sun 2021-02-21 22:39:42, Helge Deller wrote: On 2/19/21 5:33 PM, John Ogness wrote: Added CC: linux-par...@vger.kernel.org On 2021-02-19, John Ogness wrote: diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-22 Thread John Ogness
On 2021-02-22, Petr Mladek wrote: diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 20c21a25143d..401df370832b 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c +/* Return a consistent copy of @syslog_seq. */ +static u64

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-22 Thread Petr Mladek
On Sun 2021-02-21 22:39:42, Helge Deller wrote: > On 2/19/21 5:33 PM, John Ogness wrote: > > Added CC: linux-par...@vger.kernel.org > > > > On 2021-02-19, John Ogness wrote: > > > > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > > > > index 20c21a25143d..401df370832b 100644 >

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-22 Thread Petr Mladek
On Fri 2021-02-19 15:45:21, John Ogness wrote: > On 2021-02-19, Petr Mladek wrote: > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > >> index 20c21a25143d..401df370832b 100644 > >> --- a/kernel/printk/printk.c > >> +++ b/kernel/printk/printk.c > >> +/* Return a consistent copy

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-21 Thread Helge Deller
On 2/19/21 5:33 PM, John Ogness wrote: Added CC: linux-par...@vger.kernel.org On 2021-02-19, John Ogness wrote: diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 20c21a25143d..401df370832b 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c +/* Return a

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-19 Thread John Ogness
Added CC: linux-par...@vger.kernel.org On 2021-02-19, John Ogness wrote: >>> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >>> index 20c21a25143d..401df370832b 100644 >>> --- a/kernel/printk/printk.c >>> +++ b/kernel/printk/printk.c >>> +/* Return a consistent copy of @syslog_seq.

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-19 Thread John Ogness
On 2021-02-19, Petr Mladek wrote: >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> index 20c21a25143d..401df370832b 100644 >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c >> +/* Return a consistent copy of @syslog_seq. */ >> +static u64 read_syslog_seq_irq(void)

Re: [PATCH printk-rework 08/14] printk: add syslog_lock

2021-02-19 Thread Petr Mladek
On Thu 2021-02-18 09:18:11, John Ogness wrote: > The global variables @syslog_seq, @syslog_partial, @syslog_time > and write access to @clear_seq are protected by @logbuf_lock. > Once @logbuf_lock is removed, these variables will need their > own synchronization method. Introduce @syslog_lock for