Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-26 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 02:21:12PM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 07:17:41PM +0100, Peter Zijlstra wrote: > > On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > > > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > > > > > Still, better

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-26 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 02:21:12PM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 07:17:41PM +0100, Peter Zijlstra wrote: > > On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > > > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > > > > > Still, better

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 07:17:41PM +0100, Peter Zijlstra wrote: > On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > > > Still, better safe than sorry. It was a rather big change in behaviour, > > > so it

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 07:17:41PM +0100, Peter Zijlstra wrote: > On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > > > Still, better safe than sorry. It was a rather big change in behaviour, > > > so it

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Steven Rostedt
On Mon, 12 Nov 2018 19:17:41 +0100 Peter Zijlstra wrote: > On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > > > Still, better safe than sorry. It was a rather big change in behaviour, > > > so it wouldn't

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Steven Rostedt
On Mon, 12 Nov 2018 19:17:41 +0100 Peter Zijlstra wrote: > On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > > > Still, better safe than sorry. It was a rather big change in behaviour, > > > so it wouldn't

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Peter Zijlstra
On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > Still, better safe than sorry. It was a rather big change in behaviour, > > so it wouldn't have been strange to call that out. > > This guy: > > 45975c7d21a1

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Peter Zijlstra
On Mon, Nov 12, 2018 at 05:28:52AM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > > Still, better safe than sorry. It was a rather big change in behaviour, > > so it wouldn't have been strange to call that out. > > This guy: > > 45975c7d21a1

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 06:24:55PM -0800, Paul E. McKenney wrote: > > > > > There were quite a few commits involved in making this happen. Perhaps > > > > the most pertinent are these: > > > > > > > > 3e3100989869 ("rcu: Defer

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 10:00:47AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 06:24:55PM -0800, Paul E. McKenney wrote: > > > > > There were quite a few commits involved in making this happen. Perhaps > > > > the most pertinent are these: > > > > > > > > 3e3100989869 ("rcu: Defer

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 06:24:55PM -0800, Paul E. McKenney wrote: > > > There were quite a few commits involved in making this happen. Perhaps > > > the most pertinent are these: > > > > > > 3e3100989869 ("rcu: Defer reporting RCU-preempt quiescent states when > > > disabled") > > >

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-12 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 06:24:55PM -0800, Paul E. McKenney wrote: > > > There were quite a few commits involved in making this happen. Perhaps > > > the most pertinent are these: > > > > > > 3e3100989869 ("rcu: Defer reporting RCU-preempt quiescent states when > > > disabled") > > >

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 03:07:10AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 05:47:36PM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 01:53:29AM +0100, Peter Zijlstra wrote: > > > On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > > > > On Mon, Nov 12,

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 03:07:10AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 05:47:36PM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 01:53:29AM +0100, Peter Zijlstra wrote: > > > On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > > > > On Mon, Nov 12,

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 05:47:36PM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 01:53:29AM +0100, Peter Zijlstra wrote: > > On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > > > On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > > > > On Sun, Nov 11,

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 05:47:36PM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 01:53:29AM +0100, Peter Zijlstra wrote: > > On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > > > On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > > > > On Sun, Nov 11,

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 01:53:29AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > > > On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > > > > Now that

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 01:53:29AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > > On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > > > On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > > > > Now that

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > > On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > > > Now that synchronize_rcu() waits for preempt-disable regions of code > > > as well as RCU

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 04:45:28PM -0800, Paul E. McKenney wrote: > On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > > On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > > > Now that synchronize_rcu() waits for preempt-disable regions of code > > > as well as RCU

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > > Now that synchronize_rcu() waits for preempt-disable regions of code > > as well as RCU read-side critical sections, synchronize_sched() can be > > replaced by

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Paul E. McKenney
On Mon, Nov 12, 2018 at 01:12:33AM +0100, Peter Zijlstra wrote: > On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > > Now that synchronize_rcu() waits for preempt-disable regions of code > > as well as RCU read-side critical sections, synchronize_sched() can be > > replaced by

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > Now that synchronize_rcu() waits for preempt-disable regions of code > as well as RCU read-side critical sections, synchronize_sched() can be > replaced by synchronize_rcu(). This commit therefore makes this change. Yes, but it

Re: [PATCH tip/core/rcu 23/41] sched: Replace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Peter Zijlstra
On Sun, Nov 11, 2018 at 11:43:52AM -0800, Paul E. McKenney wrote: > Now that synchronize_rcu() waits for preempt-disable regions of code > as well as RCU read-side critical sections, synchronize_sched() can be > replaced by synchronize_rcu(). This commit therefore makes this change. Yes, but it