On 6/10/16 14:14, Michal Hocko wrote:
> On Fri 10-06-16 08:40:30, Chen Gang wrote:
>>
>> On 6/9/16 23:46, Michal Hocko wrote:
> [...]
>>> That's being said, I appreciate an interest in making the code cleaner
>>> but try to think whether these changes are actually helpful and who is
>>> going to
On 6/10/16 14:14, Michal Hocko wrote:
> On Fri 10-06-16 08:40:30, Chen Gang wrote:
>>
>> On 6/9/16 23:46, Michal Hocko wrote:
> [...]
>>> That's being said, I appreciate an interest in making the code cleaner
>>> but try to think whether these changes are actually helpful and who is
>>> going to
On Fri 10-06-16 08:40:30, Chen Gang wrote:
>
> On 6/9/16 23:46, Michal Hocko wrote:
[...]
> > That's being said, I appreciate an interest in making the code cleaner
> > but try to think whether these changes are actually helpful and who is
> > going to benefit from them.
> >
>
> For me, another
On Fri 10-06-16 08:40:30, Chen Gang wrote:
>
> On 6/9/16 23:46, Michal Hocko wrote:
[...]
> > That's being said, I appreciate an interest in making the code cleaner
> > but try to think whether these changes are actually helpful and who is
> > going to benefit from them.
> >
>
> For me, another
On 6/9/16 23:46, Michal Hocko wrote:
> On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote:
>> From: Chen Gang
>>
>> Merge several statements to one return statement, since the new return
>> statement is still simple enough.
>>
>> Try to let the second line
On 6/9/16 23:46, Michal Hocko wrote:
> On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote:
>> From: Chen Gang
>>
>> Merge several statements to one return statement, since the new return
>> statement is still simple enough.
>>
>> Try to let the second line function parameters almost align
On 6/10/16 01:39, Rik van Riel wrote:
> On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote:
>> From: Chen Gang
>>
>> Merge several statements to one return statement, since the new
>> return
>> statement is still simple enough.
>
> This code is not
On 6/10/16 01:39, Rik van Riel wrote:
> On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote:
>> From: Chen Gang
>>
>> Merge several statements to one return statement, since the new
>> return
>> statement is still simple enough.
>
> This code is not simple, and any change that
>
On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote:
> From: Chen Gang
>
> Merge several statements to one return statement, since the new
> return
> statement is still simple enough.
This code is not simple, and any change that
makes it harder to read
On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote:
> From: Chen Gang
>
> Merge several statements to one return statement, since the new
> return
> statement is still simple enough.
This code is not simple, and any change that
makes it harder to read needs a good reason.
At
On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote:
> From: Chen Gang
>
> Merge several statements to one return statement, since the new return
> statement is still simple enough.
>
> Try to let the second line function parameters almost align with the
> first
On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote:
> From: Chen Gang
>
> Merge several statements to one return statement, since the new return
> statement is still simple enough.
>
> Try to let the second line function parameters almost align with the
> first line parameter (try to be
12 matches
Mail list logo