Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-10 Thread Chen Gang
On 6/10/16 14:14, Michal Hocko wrote: > On Fri 10-06-16 08:40:30, Chen Gang wrote: >> >> On 6/9/16 23:46, Michal Hocko wrote: > [...] >>> That's being said, I appreciate an interest in making the code cleaner >>> but try to think whether these changes are actually helpful and who is >>> going to

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-10 Thread Chen Gang
On 6/10/16 14:14, Michal Hocko wrote: > On Fri 10-06-16 08:40:30, Chen Gang wrote: >> >> On 6/9/16 23:46, Michal Hocko wrote: > [...] >>> That's being said, I appreciate an interest in making the code cleaner >>> but try to think whether these changes are actually helpful and who is >>> going to

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-10 Thread Michal Hocko
On Fri 10-06-16 08:40:30, Chen Gang wrote: > > On 6/9/16 23:46, Michal Hocko wrote: [...] > > That's being said, I appreciate an interest in making the code cleaner > > but try to think whether these changes are actually helpful and who is > > going to benefit from them. > > > > For me, another

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-10 Thread Michal Hocko
On Fri 10-06-16 08:40:30, Chen Gang wrote: > > On 6/9/16 23:46, Michal Hocko wrote: [...] > > That's being said, I appreciate an interest in making the code cleaner > > but try to think whether these changes are actually helpful and who is > > going to benefit from them. > > > > For me, another

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Chen Gang
On 6/9/16 23:46, Michal Hocko wrote: > On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote: >> From: Chen Gang >> >> Merge several statements to one return statement, since the new return >> statement is still simple enough. >> >> Try to let the second line

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Chen Gang
On 6/9/16 23:46, Michal Hocko wrote: > On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote: >> From: Chen Gang >> >> Merge several statements to one return statement, since the new return >> statement is still simple enough. >> >> Try to let the second line function parameters almost align

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Chen Gang
On 6/10/16 01:39, Rik van Riel wrote: > On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote: >> From: Chen Gang >> >> Merge several statements to one return statement, since the new >> return >> statement is still simple enough. > > This code is not

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Chen Gang
On 6/10/16 01:39, Rik van Riel wrote: > On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote: >> From: Chen Gang >> >> Merge several statements to one return statement, since the new >> return >> statement is still simple enough. > > This code is not simple, and any change that >

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Rik van Riel
On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote: > From: Chen Gang > > Merge several statements to one return statement, since the new > return > statement is still simple enough. This code is not simple, and any change that makes it harder to read

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Rik van Riel
On Thu, 2016-06-09 at 23:23 +0800, cheng...@emindsoft.com.cn wrote: > From: Chen Gang > > Merge several statements to one return statement, since the new > return > statement is still simple enough. This code is not simple, and any change that makes it harder to read needs a good reason. At

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Michal Hocko
On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote: > From: Chen Gang > > Merge several statements to one return statement, since the new return > statement is still simple enough. > > Try to let the second line function parameters almost align with the > first

Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

2016-06-09 Thread Michal Hocko
On Thu 09-06-16 23:23:52, cheng...@emindsoft.com.cn wrote: > From: Chen Gang > > Merge several statements to one return statement, since the new return > statement is still simple enough. > > Try to let the second line function parameters almost align with the > first line parameter (try to be