Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-15 Thread Stephen Zhang
Masahiro Yamada 于2021年2月15日周一 上午1:10写道: > > So, what is the problem? > > > > > -- > Best Regards > Masahiro Yamada Okay,it seems that I misunderstood what you said before. -- Best Regards Stephen Zhang

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-15 Thread Stephen Zhang
Nathan Chancellor 于2021年2月15日周一 上午7:28写道: > > This will actually work for the regular build system as it uses the full > path to the files when O= is outside of the source tree. My comment > applies only to the tools/ build system, which Masahiro has explicitly > said he does not want this script

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-14 Thread Nathan Chancellor
On Sun, Feb 14, 2021 at 07:49:22PM +0800, Stephen Zhang wrote: > Masahiro Yamada 于2021年2月13日周六 下午8:46写道: > > This is the steps I tested. > > > > > > masahiro@oscar:~/ref/linux$ make O=build defconfig all -j24 > > [ snip ] > > masahiro@oscar:~/ref/linux$ > >

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-14 Thread Masahiro Yamada
On Sun, Feb 14, 2021 at 8:49 PM Stephen Zhang wrote: > > Masahiro Yamada 于2021年2月13日周六 下午8:46写道: > > This is the steps I tested. > > > > > > masahiro@oscar:~/ref/linux$ make O=build defconfig all -j24 > > [ snip ] > > masahiro@oscar:~/ref/linux$ > >

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-14 Thread Stephen Zhang
Masahiro Yamada 于2021年2月13日周六 下午8:46写道: > This is the steps I tested. > > > masahiro@oscar:~/ref/linux$ make O=build defconfig all -j24 > [ snip ] > masahiro@oscar:~/ref/linux$ > ./scripts/clang-tools/gen_compile_commands.py -d build > masahiro@oscar:~/ref/linux$ grep '"file":'

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-13 Thread Masahiro Yamada
On Fri, Feb 12, 2021 at 8:20 PM Stephen Zhang wrote: > > Masahiro Yamada 于2021年2月11日周四 下午10:16写道: > > Please stop. > > > > > > Commit 6ca4c6d25949117dc5b4845612e290b6d89e70a8 > > removed the tools/ support. > > > > > > There exist two build systems in the Linux source tree. > > Kbuild covers the

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-12 Thread Stephen Zhang
Masahiro Yamada 于2021年2月11日周四 下午10:16写道: > Please stop. > > > Commit 6ca4c6d25949117dc5b4845612e290b6d89e70a8 > removed the tools/ support. > > > There exist two build systems in the Linux source tree. > Kbuild covers the entire tree except tools/. > The tools/ directory adopts a different build

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-11 Thread Masahiro Yamada
On Thu, Feb 11, 2021 at 10:48 PM Stephen Zhang wrote: > > Nathan Chancellor 于2021年2月11日周四 上午2:24写道: > > > > On Wed, Feb 10, 2021 at 08:15:27PM +0800, Stephen Zhang wrote: > > > Nathan Chancellor 于2021年2月10日周三 上午3:27写道: > > > > > > > Just as an FYI, your email was HTML, which means it won't hit

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-11 Thread Stephen Zhang
Nathan Chancellor 于2021年2月11日周四 上午2:24写道: > > On Wed, Feb 10, 2021 at 08:15:27PM +0800, Stephen Zhang wrote: > > Nathan Chancellor 于2021年2月10日周三 上午3:27写道: > > > > > Just as an FYI, your email was HTML, which means it won't hit LKML. > > > > > > Thanks for pointing that out. The existence of a

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-10 Thread Tom Roeder
On Tue, Feb 09, 2021 at 12:27:29PM -0700, Nathan Chancellor wrote: On Tue, Feb 09, 2021 at 09:56:20PM +0800, Stephen Zhang wrote: Nathan Chancellor 于2021年2月9日周二 上午3:54写道: > On Mon, Feb 08, 2021 at 07:28:57PM +0800, Stephen Zhang wrote: > > The default source directory is set equal to build

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-10 Thread Nathan Chancellor
On Wed, Feb 10, 2021 at 08:15:27PM +0800, Stephen Zhang wrote: > Nathan Chancellor 于2021年2月10日周三 上午3:27写道: > > > Just as an FYI, your email was HTML, which means it won't hit LKML. > > > Thanks for pointing that out. The existence of a GFW makes it difficult for > me to connect > to the mail

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-09 Thread Nathan Chancellor
On Tue, Feb 09, 2021 at 09:56:20PM +0800, Stephen Zhang wrote: > Nathan Chancellor 于2021年2月9日周二 上午3:54写道: > > > On Mon, Feb 08, 2021 at 07:28:57PM +0800, Stephen Zhang wrote: > > > The default source directory is set equal to build directory which > > > specified by "-d".But it is designed to be

Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory

2021-02-08 Thread Nathan Chancellor
On Mon, Feb 08, 2021 at 07:28:57PM +0800, Stephen Zhang wrote: > The default source directory is set equal to build directory which > specified by "-d".But it is designed to be set to the current working > directoy by default, as the help messge says.It makes a differece when > source directory