Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-19 Thread Wei Liu
On Mon, Oct 19, 2020 at 03:02:22AM +, Michael Kelley wrote: > From: Olaf Hering Sent: Thursday, October 8, 2020 12:12 AM > > > > It is not an error if a the host requests to balloon down, but the VM > > Spurious word "a" > > > refuses to do so. Without this change a warning is logged in

Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-19 Thread Olaf Hering
Am Mon, 19 Oct 2020 02:58:08 + schrieb Michael Kelley : > I think we should take the patch. Thanks. I just briefly looked at the code, did not understand much of it. But it feels like the math uses the wrong input. I think its is not the 'pr_warn' that needs changing, the 'Fixes' tag would

RE: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-18 Thread Michael Kelley
From: Olaf Hering Sent: Thursday, October 8, 2020 12:12 AM > > It is not an error if a the host requests to balloon down, but the VM Spurious word "a" > refuses to do so. Without this change a warning is logged in dmesg > every five minutes. > > Fixes commit b3bb97b8a49f3 This "Fixes" line

RE: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-18 Thread Michael Kelley
From: Wei Liu > > On Tue, Oct 13, 2020 at 11:19:21AM +0200, Olaf Hering wrote: > > Am Tue, 13 Oct 2020 09:17:17 + > > schrieb Wei Liu : > > > > > So ... this patch is not needed anymore? > > > > Why? A message is generated every 5 minutes. Unclear why this remained > > unnoticed since at

Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-13 Thread Olaf Hering
Am Tue, 13 Oct 2020 11:19:21 +0200 schrieb Olaf Hering : > A message is generated every 5 minutes. Unclear why this remained unnoticed > since at least v5.3. I have added debug to my distro kernel to see what the > involved variable values are. More info later today. The actual values for

Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-13 Thread Wei Liu
On Tue, Oct 13, 2020 at 11:19:21AM +0200, Olaf Hering wrote: > Am Tue, 13 Oct 2020 09:17:17 + > schrieb Wei Liu : > > > So ... this patch is not needed anymore? > > Why? A message is generated every 5 minutes. Unclear why this remained > unnoticed since at least v5.3. I have added debug to

Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-13 Thread Olaf Hering
Am Tue, 13 Oct 2020 09:17:17 + schrieb Wei Liu : > So ... this patch is not needed anymore? Why? A message is generated every 5 minutes. Unclear why this remained unnoticed since at least v5.3. I have added debug to my distro kernel to see what the involved variable values are. More info

Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-13 Thread Wei Liu
On Thu, Oct 08, 2020 at 09:15:39AM +0200, Olaf Hering wrote: > Am Thu, 8 Oct 2020 09:12:15 +0200 > schrieb Olaf Hering : > > > warning is logged in dmesg > > Actually it is logged on the system console, depending on how logging is > configured. > So ... this patch is not needed anymore?

Re: [PATCH v1] hv_balloon: disable warning when floor reached

2020-10-08 Thread Olaf Hering
Am Thu, 8 Oct 2020 09:12:15 +0200 schrieb Olaf Hering : > warning is logged in dmesg Actually it is logged on the system console, depending on how logging is configured. Olaf pgpdjkpjAh1xK.pgp Description: Digitale Signatur von OpenPGP