Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On 03/08/2018 03:43 PM, Greg KH wrote: On Thu, Mar 08, 2018 at 03:29:48PM -0800, sathyanarayanan kuppuswamy wrote: On 03/08/2018 12:54 AM, Oliver Neukum wrote: Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan kuppuswamy : On 03/07/2018 12:58 PM, Greg KH wrote: So I

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On 03/08/2018 03:43 PM, Greg KH wrote: On Thu, Mar 08, 2018 at 03:29:48PM -0800, sathyanarayanan kuppuswamy wrote: On 03/08/2018 12:54 AM, Oliver Neukum wrote: Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan kuppuswamy : On 03/07/2018 12:58 PM, Greg KH wrote: So I

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On Thu, Mar 08, 2018 at 03:29:48PM -0800, sathyanarayanan kuppuswamy wrote: > > > On 03/08/2018 12:54 AM, Oliver Neukum wrote: > > Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan > > kuppuswamy : > > > On 03/07/2018 12:58 PM, Greg KH wrote: > > > > So I don't see why your

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On Thu, Mar 08, 2018 at 03:29:48PM -0800, sathyanarayanan kuppuswamy wrote: > > > On 03/08/2018 12:54 AM, Oliver Neukum wrote: > > Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan > > kuppuswamy : > > > On 03/07/2018 12:58 PM, Greg KH wrote: > > > > So I don't see why your

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On 03/08/2018 12:54 AM, Oliver Neukum wrote: Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan kuppuswamy : On 03/07/2018 12:58 PM, Greg KH wrote: So I don't see why your check is needed, what other code path would ever call this function in a way that the bounds check

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On 03/08/2018 12:54 AM, Oliver Neukum wrote: Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan kuppuswamy : On 03/07/2018 12:58 PM, Greg KH wrote: So I don't see why your check is needed, what other code path would ever call this function in a way that the bounds check

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On Wed, Mar 07, 2018 at 01:41:51PM -0800, sathyanarayanan kuppuswamy wrote: > > > On 03/07/2018 12:58 PM, Greg KH wrote: > > On Wed, Mar 07, 2018 at 12:23:56PM -0800, > > sathyanarayanan.kuppusw...@linux.intel.com wrote: > > > From: Kuppuswamy Sathyanarayanan > > >

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On Wed, Mar 07, 2018 at 01:41:51PM -0800, sathyanarayanan kuppuswamy wrote: > > > On 03/07/2018 12:58 PM, Greg KH wrote: > > On Wed, Mar 07, 2018 at 12:23:56PM -0800, > > sathyanarayanan.kuppusw...@linux.intel.com wrote: > > > From: Kuppuswamy Sathyanarayanan > > > > > > > > > In

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan kuppuswamy : > > On 03/07/2018 12:58 PM, Greg KH wrote: > > So I don't see why your check is needed, what other code path would ever > > call this function in a way that the bounds check would be needed? > void

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

Am Mittwoch, den 07.03.2018, 13:41 -0800 schrieb sathyanarayanan kuppuswamy : > > On 03/07/2018 12:58 PM, Greg KH wrote: > > So I don't see why your check is needed, what other code path would ever > > call this function in a way that the bounds check would be needed? > void

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On 03/07/2018 12:58 PM, Greg KH wrote: On Wed, Mar 07, 2018 at 12:23:56PM -0800, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan In usb_serial_generic_submit_read_urb() function we are accessing the

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On 03/07/2018 12:58 PM, Greg KH wrote: On Wed, Mar 07, 2018 at 12:23:56PM -0800, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan In usb_serial_generic_submit_read_urb() function we are accessing the port->read_urbs array without any boundry checks. This

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On Wed, Mar 07, 2018 at 12:23:56PM -0800, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > In usb_serial_generic_submit_read_urb() function we are accessing the > port->read_urbs array without any boundry

Re: [PATCH v1 1/1] USB: serial: Add boundry check for read_urbs array access

On Wed, Mar 07, 2018 at 12:23:56PM -0800, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > In usb_serial_generic_submit_read_urb() function we are accessing the > port->read_urbs array without any boundry checks. This might lead to > kernel panic when