Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 19:45:46 -0700 Hemant Kumar wrote: > +/* .driver_data stores max mtu */ > +static const struct mhi_device_id mhi_uci_match_table[] = { > + { .chan = "LOOPBACK", .driver_data = 0x1000}, > + {}, > +}; > +MODULE_DEVICE_TABLE(mhi, mhi_uci_match_table); I forgot to follow

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Manivannan Sadhasivam
hi Hemant, On Fri, Oct 30, 2020 at 06:26:38PM -0700, Hemant Kumar wrote: > Hi Mani, > > On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote: > > Hi Hemant, > > > > On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: > > > This MHI client driver allows userspace clients to transfer > > >

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Hemant Kumar
Hi Mani, On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote: Hi Hemant, On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Hemant Kumar
Hi Randy, On 10/29/20 10:48 PM, Randy Dunlap wrote: On 10/29/20 7:45 PM, Hemant Kumar wrote: diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig index e841c10..476cc55 100644 --- a/drivers/bus/mhi/Kconfig +++ b/drivers/bus/mhi/Kconfig @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Manivannan Sadhasivam
Hi Hemant, On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Driver instantiates UCI device object which is associated to device > file node. UCI

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-29 Thread Randy Dunlap
On 10/29/20 7:45 PM, Hemant Kumar wrote: > diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig > index e841c10..476cc55 100644 > --- a/drivers/bus/mhi/Kconfig > +++ b/drivers/bus/mhi/Kconfig > @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG > Enable debugfs support for use with the MHI