Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread David Miller
From: Stephen Hemminger Date: Mon, 20 Jul 2020 13:56:50 -0700 > It matters because the problem is generic, not just to the netvsc driver. > For example, BPF programs and netfilter rules will see different packets > when send is through AF_PACKET than they would see for sends from the > kernel

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 17:22:49 -0400 Willem de Bruijn wrote: > On Mon, Jul 20, 2020 at 4:57 PM Stephen Hemminger > wrote: > > > > On Mon, 20 Jul 2020 09:52:27 -0400 > > Willem de Bruijn wrote: > > > > > On Mon, Jul 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2) > > > wrote: > > > > > > > >

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Willem de Bruijn
On Mon, Jul 20, 2020 at 4:57 PM Stephen Hemminger wrote: > > On Mon, 20 Jul 2020 09:52:27 -0400 > Willem de Bruijn wrote: > > > On Mon, Jul 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2) > > wrote: > > > > > > +Stephen Hemminger > > > > > > Hi Willem, > > > Thanks for looking into the code, I

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 09:52:27 -0400 Willem de Bruijn wrote: > On Mon, Jul 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2) > wrote: > > > > +Stephen Hemminger > > > > Hi Willem, > > Thanks for looking into the code, I understand that this is more of a > > generic problem wherein many of the

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Sriram Krishnan (srirakr2)
I have moved the code to the driver and pushed a new patch due to the below highlighted issues. Stephen H, Please let me know if you have any concerns localising the changes to the netvsc driver. Thanks, Sriram On 20/07/20, 7:23 PM, "Willem de Bruijn" wrote: On Mon, Jul 20, 2020 at

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Willem de Bruijn
On Mon, Jul 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2) wrote: > > +Stephen Hemminger > > Hi Willem, > Thanks for looking into the code, I understand that this is more of a generic > problem wherein many of the filtering functions assume the vlan tag to be in > the skb rather than in the

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-18 Thread kernel test robot
Hi Sriram, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-linux-mm/master] [also build test WARNING on sparc-next/master linus/master v5.8-rc5 next-20200717] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-18 Thread Willem de Bruijn
On Sat, Jul 18, 2020 at 5:25 AM Sriram Krishnan wrote: > > When an application sends with AF_PACKET and places a vlan header on > the raw packet; then the AF_PACKET needs to move the tag into the skb > so that it gets processed normally through the rest of the transmit > path. > > This is