Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2019-10-18 Thread Jim Mattson
On Thu, Aug 3, 2017 at 6:23 PM Wanpeng Li wrote: > Thanks Radim. :) In addition, I will think more about it and figure > out a finial solution. Have you had any thoughts on a final solution? We're seeing incorrect behavior with an L1 hypervisor running under qemu with "-machine

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-03 Thread Wanpeng Li
2017-08-03 21:46 GMT+08:00 Radim Krčmář : > 2017-07-31 19:25-0700, Wanpeng Li: >> From: Wanpeng Li >> >> [ cut here ] >> WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 >> nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] >>

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-03 Thread Wanpeng Li
2017-08-03 21:46 GMT+08:00 Radim Krčmář : > 2017-07-31 19:25-0700, Wanpeng Li: >> From: Wanpeng Li >> >> [ cut here ] >> WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 >> nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] >> CPU: 5 PID: 2288 Comm: qemu-system-x86 Not

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-03 Thread Radim Krčmář
2017-07-31 19:25-0700, Wanpeng Li: > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 > nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] > CPU: 5 PID: 2288 Comm: qemu-system-x86 Not tainted 4.13.0-rc2+ #7 >

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-03 Thread Radim Krčmář
2017-07-31 19:25-0700, Wanpeng Li: > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 > nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] > CPU: 5 PID: 2288 Comm: qemu-system-x86 Not tainted 4.13.0-rc2+ #7 > RIP:

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-02 Thread Paolo Bonzini
On 02/08/2017 10:05, Wanpeng Li wrote: >>> >>> SDM says that with acknowledge interrupt on exit, bit 31 of the VM-exit >>> interrupt information (valid interrupt) is always set to 1 on >>> EXIT_REASON_EXTERNAL_INTERRUPT. We don't want to break hypervisors >>> expecting an interrupt in that case,

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-02 Thread Paolo Bonzini
On 02/08/2017 10:05, Wanpeng Li wrote: >>> >>> SDM says that with acknowledge interrupt on exit, bit 31 of the VM-exit >>> interrupt information (valid interrupt) is always set to 1 on >>> EXIT_REASON_EXTERNAL_INTERRUPT. We don't want to break hypervisors >>> expecting an interrupt in that case,

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-02 Thread Wanpeng Li
2017-08-02 6:42 GMT+08:00 Wanpeng Li : > 2017-08-02 3:59 GMT+08:00 Radim Krčmář : >> 2017-07-31 19:25-0700, Wanpeng Li: >>> From: Wanpeng Li >>> >>> [ cut here ] >>> WARNING: CPU: 5 PID: 2288 at

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-02 Thread Wanpeng Li
2017-08-02 6:42 GMT+08:00 Wanpeng Li : > 2017-08-02 3:59 GMT+08:00 Radim Krčmář : >> 2017-07-31 19:25-0700, Wanpeng Li: >>> From: Wanpeng Li >>> >>> [ cut here ] >>> WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 >>> nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] >>>

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-01 Thread Wanpeng Li
2017-08-02 3:59 GMT+08:00 Radim Krčmář : > 2017-07-31 19:25-0700, Wanpeng Li: >> From: Wanpeng Li >> >> [ cut here ] >> WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 >> nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] >> CPU:

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-01 Thread Wanpeng Li
2017-08-02 3:59 GMT+08:00 Radim Krčmář : > 2017-07-31 19:25-0700, Wanpeng Li: >> From: Wanpeng Li >> >> [ cut here ] >> WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 >> nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] >> CPU: 5 PID: 2288 Comm: qemu-system-x86 Not

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-01 Thread Radim Krčmář
2017-07-31 19:25-0700, Wanpeng Li: > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 > nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] > CPU: 5 PID: 2288 Comm: qemu-system-x86 Not tainted 4.13.0-rc2+ #7 >

Re: [PATCH v2] KVM: nVMX: Fix attempting to emulate "Acknowledge interrupt on exit" when there is no interrupt which L1 requires to inject to L2

2017-08-01 Thread Radim Krčmář
2017-07-31 19:25-0700, Wanpeng Li: > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 5 PID: 2288 at arch/x86/kvm/vmx.c:11124 > nested_vmx_vmexit+0xd64/0xd70 [kvm_intel] > CPU: 5 PID: 2288 Comm: qemu-system-x86 Not tainted 4.13.0-rc2+ #7 > RIP: