Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-10 Thread Changbin Du
On Tue, Sep 10, 2019 at 05:28:04AM -0400, Steven Rostedt wrote: > On Tue, 10 Sep 2019 08:33:23 +0800 > Changbin Du wrote: > > > > > > > bool ftrace_lookup_ip(struct ftrace_hash *hash, unsigned long ip, bool > > > empty_result) > > > { > > > if (ftrace_hash_empty(hash)) > > > return

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-10 Thread Steven Rostedt
On Tue, 10 Sep 2019 08:33:23 +0800 Changbin Du wrote: > > > > bool ftrace_lookup_ip(struct ftrace_hash *hash, unsigned long ip, bool > > empty_result) > > { > > if (ftrace_hash_empty(hash)) > > return empty_result; > > > > return __ftrace_lookup_ip(hash, ip); > > } > > >

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-09 Thread Changbin Du
On Mon, Sep 09, 2019 at 10:54:24AM -0400, Steven Rostedt wrote: > On Mon, 9 Sep 2019 08:31:59 +0800 > Changbin Du wrote: > > > Function ftrace_lookup_ip() will check empty hash table. So we don't > > need extra check outside. > > > > Signed-off-by: Changbin Du > > > > --- > > v2: fix

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-09 Thread Changbin Du
On Mon, Sep 09, 2019 at 10:54:24AM -0400, Steven Rostedt wrote: > On Mon, 9 Sep 2019 08:31:59 +0800 > Changbin Du wrote: > > > Function ftrace_lookup_ip() will check empty hash table. So we don't > > need extra check outside. > > > > Signed-off-by: Changbin Du > > > > --- > > v2: fix

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-09 Thread Steven Rostedt
On Mon, 9 Sep 2019 08:31:59 +0800 Changbin Du wrote: > Function ftrace_lookup_ip() will check empty hash table. So we don't > need extra check outside. > > Signed-off-by: Changbin Du > > --- > v2: fix incorrect code remove. > --- > kernel/trace/ftrace.c | 9 ++--- > 1 file changed, 2