Re: [PATCH v2] gnss: get serial speed from subdrivers

2019-05-17 Thread Loys Ollivier
On Thu 16 May 2019 at 19:02, Robin Murphy wrote: >> -/* >> - * FIXME: need to provide subdriver defaults or separate dt parsing from >> - * allocation. >> - */ >> static int gnss_serial_parse_dt(struct serdev_device *serdev) >> { >> struct gnss_serial *gserial =

Re: [PATCH v2] gnss: get serial speed from subdrivers

2019-05-16 Thread Robin Murphy
On 16/05/2019 17:37, Loys Ollivier wrote: The default serial speed was hardcoded in the code. Rename current-speed to default-speed. Add a function parameter that lets the subdrivers specify their default speed. If not specified fallback to the device-tree default-speed. Signed-off-by: Loys