Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-01 Thread Vijay Khemka
Let me send both patches. On 4/30/19, 11:45 PM, "Greg Kroah-Hartman" wrote: On Wed, May 01, 2019 at 05:55:07AM +, Joel Stanley wrote: > On Fri, 18 Jan 2019 at 20:12, Vijay Khemka wrote: > > > > Hi Andrew, > > Thanks for this review, I will have a follow up patch for

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-01 Thread Greg Kroah-Hartman
On Wed, May 01, 2019 at 05:55:07AM +, Joel Stanley wrote: > On Fri, 18 Jan 2019 at 20:12, Vijay Khemka wrote: > > > > Hi Andrew, > > Thanks for this review, I will have a follow up patch for this return > > values. > > Did you send a follow up patch to fix the return values? > > Greg, is

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-04-30 Thread Joel Stanley
On Fri, 18 Jan 2019 at 20:12, Vijay Khemka wrote: > > Hi Andrew, > Thanks for this review, I will have a follow up patch for this return values. Did you send a follow up patch to fix the return values? Greg, is there any reason why you did not merge this one? 5.2 will have device trees that

Re: [Potential Spoof] Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-27 Thread Vijay Khemka
Hi Joel, Can you please apply this below patch to kernel 5.0. Regards -Vijay On 3/18/19, 12:46 PM, "openbmc on behalf of Vijay Khemka" wrote: Hi Joel, Can you please apply this patch as " Documentation/devicetree/bindings/mfd/aspeed-lpc.txt" has already been applied Regards

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-18 Thread Vijay Khemka
Hi Joel, Can you please apply this patch as " Documentation/devicetree/bindings/mfd/aspeed-lpc.txt" has already been applied Regards -Vijay On 3/5/19, 4:15 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Joel, Did this patch apply upstream. Somehow I can't find this patch in

Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-05 Thread Vijay Khemka
Joel, Did this patch apply upstream. Somehow I can't find this patch in linux or linux-next or our obmc dev4.19. Regards -Vijay On 1/17/19, 10:53 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 1/16/19, 10:17 PM, "Joel Stanley" wrote: On Thu, 17 Jan 2019

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-18 Thread Vijay Khemka
Hi Andrew, Thanks for this review, I will have a follow up patch for this return values. Regards -Vijay On 1/17/19, 8:58 PM, "Andrew Jeffery" wrote: Hi Vijay, Thanks for doing the work to fix the driver. Some minor queries/points below. On Thu, 17 Jan 2019, at 08:31,

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-17 Thread Andrew Jeffery
Hi Vijay, Thanks for doing the work to fix the driver. Some minor queries/points below. On Thu, 17 Jan 2019, at 08:31, Vijay Khemka wrote: > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need to define in

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-17 Thread Vijay Khemka
On 1/16/19, 10:17 PM, "Joel Stanley" wrote: On Thu, 17 Jan 2019 at 09:02, Vijay Khemka wrote: > > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need to define in devicetree. > >

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-16 Thread Joel Stanley
On Thu, 17 Jan 2019 at 09:02, Vijay Khemka wrote: > > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need to define in devicetree. > > Signed-off-by: Vijay Khemka Thanks! This looks okay to me. I tested it on one