Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-10 Thread Aaron Lu
On Tue, Oct 10, 2017 at 02:45:45PM -0700, Andrew Morton wrote: > On Tue, 10 Oct 2017 13:43:43 +0800 Aaron Lu wrote: > > > On Mon, Oct 09, 2017 at 10:19:52PM -0700, Dave Hansen wrote: > > > On 10/09/2017 07:56 PM, Aaron Lu wrote: > > > > This patch adds inline to __rmqueue()

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-10 Thread Aaron Lu
On Tue, Oct 10, 2017 at 02:45:45PM -0700, Andrew Morton wrote: > On Tue, 10 Oct 2017 13:43:43 +0800 Aaron Lu wrote: > > > On Mon, Oct 09, 2017 at 10:19:52PM -0700, Dave Hansen wrote: > > > On 10/09/2017 07:56 PM, Aaron Lu wrote: > > > > This patch adds inline to __rmqueue() and vmlinux' size

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-10 Thread Andi Kleen
> `inline' is basically advisory (or ignored) in modern gcc's. So gcc > has felt free to ignore it in __rmqueue_fallback and __rmqueue_smallest > because gcc thinks it knows best. That's why we created > __always_inline, to grab gcc by the scruff of its neck. > > So... I think this patch could

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-10 Thread Andi Kleen
> `inline' is basically advisory (or ignored) in modern gcc's. So gcc > has felt free to ignore it in __rmqueue_fallback and __rmqueue_smallest > because gcc thinks it knows best. That's why we created > __always_inline, to grab gcc by the scruff of its neck. > > So... I think this patch could

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-10 Thread Andrew Morton
On Tue, 10 Oct 2017 13:43:43 +0800 Aaron Lu wrote: > On Mon, Oct 09, 2017 at 10:19:52PM -0700, Dave Hansen wrote: > > On 10/09/2017 07:56 PM, Aaron Lu wrote: > > > This patch adds inline to __rmqueue() and vmlinux' size doesn't have any > > > change after this patch according

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-10 Thread Andrew Morton
On Tue, 10 Oct 2017 13:43:43 +0800 Aaron Lu wrote: > On Mon, Oct 09, 2017 at 10:19:52PM -0700, Dave Hansen wrote: > > On 10/09/2017 07:56 PM, Aaron Lu wrote: > > > This patch adds inline to __rmqueue() and vmlinux' size doesn't have any > > > change after this patch according to size(1). > > >

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-09 Thread Aaron Lu
On Mon, Oct 09, 2017 at 10:19:52PM -0700, Dave Hansen wrote: > On 10/09/2017 07:56 PM, Aaron Lu wrote: > > This patch adds inline to __rmqueue() and vmlinux' size doesn't have any > > change after this patch according to size(1). > > > > without this patch: > >textdata bss dec

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-09 Thread Aaron Lu
On Mon, Oct 09, 2017 at 10:19:52PM -0700, Dave Hansen wrote: > On 10/09/2017 07:56 PM, Aaron Lu wrote: > > This patch adds inline to __rmqueue() and vmlinux' size doesn't have any > > change after this patch according to size(1). > > > > without this patch: > >textdata bss dec

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-09 Thread Dave Hansen
On 10/09/2017 07:56 PM, Aaron Lu wrote: > This patch adds inline to __rmqueue() and vmlinux' size doesn't have any > change after this patch according to size(1). > > without this patch: >textdata bss dec hex filename > 9968576 5793372 17715200 33477148 1fed21c vmlinux >

Re: [PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-09 Thread Dave Hansen
On 10/09/2017 07:56 PM, Aaron Lu wrote: > This patch adds inline to __rmqueue() and vmlinux' size doesn't have any > change after this patch according to size(1). > > without this patch: >textdata bss dec hex filename > 9968576 5793372 17715200 33477148 1fed21c vmlinux >