Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check

2016-10-13 Thread Mark Rutland
On Thu, Oct 13, 2016 at 07:18:37PM +0100, Al Viro wrote: > On Thu, Oct 13, 2016 at 11:09:16AM -0700, Tai Nguyen wrote: > > In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), > > which doesn't make sense, as the pointer must be a real, valid pointer. > > This doesn't cause

Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check

2016-10-13 Thread Mark Rutland
On Thu, Oct 13, 2016 at 07:18:37PM +0100, Al Viro wrote: > On Thu, Oct 13, 2016 at 11:09:16AM -0700, Tai Nguyen wrote: > > In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), > > which doesn't make sense, as the pointer must be a real, valid pointer. > > This doesn't cause

Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 11:09:16AM -0700, Tai Nguyen wrote: > In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), > which doesn't make sense, as the pointer must be a real, valid pointer. > This doesn't cause a functional problem, as IS_ERR() will evaluate as > false, but

Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 11:09:16AM -0700, Tai Nguyen wrote: > In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), > which doesn't make sense, as the pointer must be a real, valid pointer. > This doesn't cause a functional problem, as IS_ERR() will evaluate as > false, but