Re: [PATCH v2] printk: avoid prb_first_valid_seq() where possible

2021-03-01 Thread Greg KH
On Tue, Feb 23, 2021 at 10:02:14AM +0100, Petr Mladek wrote: > On Thu 2021-02-11 18:37:52, John Ogness wrote: > > If message sizes average larger than expected (more than 32 > > characters), the data_ring will wrap before the desc_ring. Once the > > data_ring wraps, it will start invalidating

Re: [PATCH v2] printk: avoid prb_first_valid_seq() where possible

2021-02-23 Thread Petr Mladek
On Thu 2021-02-11 18:37:52, John Ogness wrote: > If message sizes average larger than expected (more than 32 > characters), the data_ring will wrap before the desc_ring. Once the > data_ring wraps, it will start invalidating descriptors. These > invalid descriptors hang around until they are

Re: [PATCH v2] printk: avoid prb_first_valid_seq() where possible

2021-02-12 Thread Sergey Senozhatsky
On (21/02/12 10:47), Petr Mladek wrote: > > Fixes: 896fbe20b4e2333fb55 ("printk: use the lockless ringbuffer") > > Reported-by: kernel test robot > > Reported-by: J. Avila > > Signed-off-by: John Ogness > > Reviewed-by: Petr Mladek > > I am going to push the patch later today. I would prefer

Re: [PATCH v2] printk: avoid prb_first_valid_seq() where possible

2021-02-12 Thread Petr Mladek
On Thu 2021-02-11 18:37:52, John Ogness wrote: > If message sizes average larger than expected (more than 32 > characters), the data_ring will wrap before the desc_ring. Once the > data_ring wraps, it will start invalidating descriptors. These > invalid descriptors hang around until they are