Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-11 Thread Qais Yousef
On 01/11/21 15:04, Peter Zijlstra wrote: > On Mon, Jan 04, 2021 at 06:26:42PM +, Qais Yousef wrote: > > > So I have a proper patch for that now, that actually turned out to be really > > tiny once you untangle exactly what is missing. > > > > Peter, bpf programs aren't considered ABIs AFAIK,

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-11 Thread Peter Zijlstra
On Mon, Jan 04, 2021 at 06:26:42PM +, Qais Yousef wrote: > So I have a proper patch for that now, that actually turned out to be really > tiny once you untangle exactly what is missing. > > Peter, bpf programs aren't considered ABIs AFAIK, do you have concerns about > that? In order to use

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-07 Thread Qais Yousef
On 01/06/21 15:42, Andrii Nakryiko wrote: > On Wed, Jan 6, 2021 at 3:27 AM Qais Yousef wrote: > > > > On 01/05/21 08:44, Alexei Starovoitov wrote: > > > > Any pointer to an example test I could base this on? > > > > > > selftests/bpf/ > > > > I was hoping for something more elaborate. I thought

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-06 Thread Andrii Nakryiko
On Wed, Jan 6, 2021 at 3:27 AM Qais Yousef wrote: > > On 01/05/21 08:44, Alexei Starovoitov wrote: > > > Any pointer to an example test I could base this on? > > > > selftests/bpf/ > > I was hoping for something more elaborate. I thought there's something already > there that do some verification

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-06 Thread Qais Yousef
On 01/05/21 08:44, Alexei Starovoitov wrote: > > Any pointer to an example test I could base this on? > > selftests/bpf/ I was hoping for something more elaborate. I thought there's something already there that do some verification for raw tracepoint that I could either extend or replicate.

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-05 Thread Alexei Starovoitov
On Tue, Jan 5, 2021 at 3:39 AM Qais Yousef wrote: > > On 01/04/21 10:59, Alexei Starovoitov wrote: > > > > > I did have a patch that allowed that. It might be worth trying to > > > > > upstream it. > > > > > It just required a new macro which could be problematic. > > > > > > > > > >

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-05 Thread Qais Yousef
On 01/04/21 10:59, Alexei Starovoitov wrote: > > > > I did have a patch that allowed that. It might be worth trying to > > > > upstream it. > > > > It just required a new macro which could be problematic. > > > > > > > >

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-04 Thread Alexei Starovoitov
On Mon, Jan 4, 2021 at 10:29 AM Qais Yousef wrote: > > On 09/08/20 09:19, Phil Auld wrote: > > Hi Quais, > > > > On Mon, Sep 07, 2020 at 12:02:24PM +0100 Qais Yousef wrote: > > > On 09/02/20 09:54, Phil Auld wrote: > > > > > > > > > > I think this decoupling is not necessary. The natural place

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-04 Thread Qais Yousef
On 09/08/20 09:19, Phil Auld wrote: > Hi Quais, > > On Mon, Sep 07, 2020 at 12:02:24PM +0100 Qais Yousef wrote: > > On 09/02/20 09:54, Phil Auld wrote: > > > > > > > > I think this decoupling is not necessary. The natural place for those > > > > scheduler trace_event based on trace_points

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-04 Thread Qais Yousef
On 09/07/20 13:13, pet...@infradead.org wrote: > On Mon, Sep 07, 2020 at 11:48:45AM +0100, Qais Yousef wrote: > > IMHO the above is a hack. Out-of-tree modules should rely on public headers > > and > > exported functions only. What you propose means that people who want to use > > these

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-08 Thread Qais Yousef
On 09/08/20 09:19, Phil Auld wrote: > Hi Quais, > > On Mon, Sep 07, 2020 at 12:02:24PM +0100 Qais Yousef wrote: > > On 09/02/20 09:54, Phil Auld wrote: > > > > > > > > I think this decoupling is not necessary. The natural place for those > > > > scheduler trace_event based on trace_points

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-08 Thread Qais Yousef
On 09/08/20 13:17, Dietmar Eggemann wrote: > On 07/09/2020 16:51, Qais Yousef wrote: > > On 09/07/20 13:13, pet...@infradead.org wrote: > >> On Mon, Sep 07, 2020 at 11:48:45AM +0100, Qais Yousef wrote: > >>> IMHO the above is a hack. Out-of-tree modules should rely on public > >>> headers and >

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-08 Thread Dietmar Eggemann
On 08/09/2020 17:17, Qais Yousef wrote: > On 09/08/20 13:17, Dietmar Eggemann wrote: >> On 07/09/2020 16:51, Qais Yousef wrote: >>> On 09/07/20 13:13, pet...@infradead.org wrote: On Mon, Sep 07, 2020 at 11:48:45AM +0100, Qais Yousef wrote: > IMHO the above is a hack. Out-of-tree modules

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-08 Thread Phil Auld
Hi Quais, On Mon, Sep 07, 2020 at 12:02:24PM +0100 Qais Yousef wrote: > On 09/02/20 09:54, Phil Auld wrote: > > > > > > I think this decoupling is not necessary. The natural place for those > > > scheduler trace_event based on trace_points extension files is > > > kernel/sched/ and here the

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-08 Thread Dietmar Eggemann
On 07/09/2020 16:51, Qais Yousef wrote: > On 09/07/20 13:13, pet...@infradead.org wrote: >> On Mon, Sep 07, 2020 at 11:48:45AM +0100, Qais Yousef wrote: >>> IMHO the above is a hack. Out-of-tree modules should rely on public headers >>> and >>> exported functions only. What you propose means that

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-07 Thread Qais Yousef
On 09/02/20 09:54, Phil Auld wrote: > > > > I think this decoupling is not necessary. The natural place for those > > scheduler trace_event based on trace_points extension files is > > kernel/sched/ and here the internal sched.h can just be included. > > > > If someone really wants to build this

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-07 Thread peterz
On Mon, Sep 07, 2020 at 11:48:45AM +0100, Qais Yousef wrote: > IMHO the above is a hack. Out-of-tree modules should rely on public headers > and > exported functions only. What you propose means that people who want to use > these tracepoints in meaningful way must have a prebuilt kernel handy.

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-07 Thread Qais Yousef
On 09/07/20 13:13, pet...@infradead.org wrote: > On Mon, Sep 07, 2020 at 11:48:45AM +0100, Qais Yousef wrote: > > IMHO the above is a hack. Out-of-tree modules should rely on public headers > > and > > exported functions only. What you propose means that people who want to use > > these

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-07 Thread Qais Yousef
Hi Dietmar On 09/02/20 12:44, Dietmar Eggemann wrote: > + Phil Auld > > On 28/08/2020 19:26, Qais Yousef wrote: > > On 08/28/20 19:10, Dietmar Eggemann wrote: > >> On 28/08/2020 12:27, Qais Yousef wrote: > >>> On 08/28/20 10:00, vincent.donnef...@arm.com wrote: > From: Vincent Donnefort >

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-02 Thread Phil Auld
On Wed, Sep 02, 2020 at 12:44:42PM +0200 Dietmar Eggemann wrote: > + Phil Auld > Thanks Dietmar. > On 28/08/2020 19:26, Qais Yousef wrote: > > On 08/28/20 19:10, Dietmar Eggemann wrote: > >> On 28/08/2020 12:27, Qais Yousef wrote: > >>> On 08/28/20 10:00, vincent.donnef...@arm.com wrote: >

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-09-02 Thread Dietmar Eggemann
+ Phil Auld On 28/08/2020 19:26, Qais Yousef wrote: > On 08/28/20 19:10, Dietmar Eggemann wrote: >> On 28/08/2020 12:27, Qais Yousef wrote: >>> On 08/28/20 10:00, vincent.donnef...@arm.com wrote: From: Vincent Donnefort [...] >> Can you remind me why we have all these helper functions

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-08-28 Thread Qais Yousef
On 08/28/20 19:10, Dietmar Eggemann wrote: > On 28/08/2020 12:27, Qais Yousef wrote: > > On 08/28/20 10:00, vincent.donnef...@arm.com wrote: > >> From: Vincent Donnefort > >> > >> rq->cpu_capacity is a key element in several scheduler parts, such as EAS > >> task placement and load balancing.

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-08-28 Thread Dietmar Eggemann
On 28/08/2020 12:27, Qais Yousef wrote: > On 08/28/20 10:00, vincent.donnef...@arm.com wrote: >> From: Vincent Donnefort >> >> rq->cpu_capacity is a key element in several scheduler parts, such as EAS >> task placement and load balancing. Tracking this value enables testing >> and/or debugging by

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2020-08-28 Thread Qais Yousef
On 08/28/20 10:00, vincent.donnef...@arm.com wrote: > From: Vincent Donnefort > > rq->cpu_capacity is a key element in several scheduler parts, such as EAS > task placement and load balancing. Tracking this value enables testing > and/or debugging by a toolkit. > > Signed-off-by: Vincent