Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Alexey Brodkin
Hi Sergei, On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > Not of_phy_connect()? I

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
On 09/07/2015 11:50 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Not of_phy_connect()? Still for checking result of phy_connect() IS_ERR() is useful. To address both

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Alexey Brodkin
Hi Sergei, On Mon, 2015-09-07 at 23:53 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > > > Still for checking result of

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
On 09/07/2015 11:50 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. To address both situations we use combined

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
On 09/07/2015 11:50 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. To address both situations we use combined

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Alexey Brodkin
Hi Sergei, On Mon, 2015-09-07 at 23:53 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > > > Still for checking result of

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Alexey Brodkin
Hi Sergei, On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > Not of_phy_connect()? I

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
On 09/07/2015 11:50 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Not of_phy_connect()? Still for checking result of phy_connect() IS_ERR() is useful. To address both