Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-18 Thread Claudiu Beznea
On 18.01.2018 01:14, Brian Norris wrote: > On Tue, Jan 16, 2018 at 10:24:59AM +0200, Claudiu Beznea wrote: >> Please explain me further. From this I understand, as a general rule, >> that the device tree binaries from, e.g. 3 years ago, should be >> compatible with, e.g. the current version of

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-18 Thread Claudiu Beznea
On 18.01.2018 01:14, Brian Norris wrote: > On Tue, Jan 16, 2018 at 10:24:59AM +0200, Claudiu Beznea wrote: >> Please explain me further. From this I understand, as a general rule, >> that the device tree binaries from, e.g. 3 years ago, should be >> compatible with, e.g. the current version of

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-17 Thread Brian Norris
On Tue, Jan 16, 2018 at 10:24:59AM +0200, Claudiu Beznea wrote: > Please explain me further. From this I understand, as a general rule, > that the device tree binaries from, e.g. 3 years ago, should be > compatible with, e.g. the current version of kernel? Yes.

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-17 Thread Brian Norris
On Tue, Jan 16, 2018 at 10:24:59AM +0200, Claudiu Beznea wrote: > Please explain me further. From this I understand, as a general rule, > that the device tree binaries from, e.g. 3 years ago, should be > compatible with, e.g. the current version of kernel? Yes.

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Claudiu Beznea
On 16.01.2018 11:07, Neil Armstrong wrote: > On 12/01/2018 15:22, Claudiu Beznea wrote: >> Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions >> and add of_pwm_xlate() which is used in all cases no mather if the OF >> bindings are with PWM flags or not. This should not affect

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Claudiu Beznea
On 16.01.2018 11:07, Neil Armstrong wrote: > On 12/01/2018 15:22, Claudiu Beznea wrote: >> Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions >> and add of_pwm_xlate() which is used in all cases no mather if the OF >> bindings are with PWM flags or not. This should not affect

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Neil Armstrong
On 12/01/2018 15:22, Claudiu Beznea wrote: > Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions > and add of_pwm_xlate() which is used in all cases no mather if the OF > bindings are with PWM flags or not. This should not affect the old > behavior since the xlate will be based on

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Neil Armstrong
On 12/01/2018 15:22, Claudiu Beznea wrote: > Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions > and add of_pwm_xlate() which is used in all cases no mather if the OF > bindings are with PWM flags or not. This should not affect the old > behavior since the xlate will be based on

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Claudiu Beznea
On 15.01.2018 22:27, Andy Shevchenko wrote: > On Mon, Jan 15, 2018 at 10:41 AM, Claudiu Beznea > wrote: > >> For this driver, the PWM bindings were changed (I did a grep by >> "google,cros-ec-pwm" >> and located only: >>

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Claudiu Beznea
On 15.01.2018 22:27, Andy Shevchenko wrote: > On Mon, Jan 15, 2018 at 10:41 AM, Claudiu Beznea > wrote: > >> For this driver, the PWM bindings were changed (I did a grep by >> "google,cros-ec-pwm" >> and located only: >> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Andy Shevchenko
On Mon, Jan 15, 2018 at 10:41 AM, Claudiu Beznea wrote: > For this driver, the PWM bindings were changed (I did a grep by > "google,cros-ec-pwm" > and located only: > arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi >

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Andy Shevchenko
On Mon, Jan 15, 2018 at 10:41 AM, Claudiu Beznea wrote: > For this driver, the PWM bindings were changed (I did a grep by > "google,cros-ec-pwm" > and located only: > arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi > files) and changed the

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Claudiu Beznea
On 15.01.2018 10:41, Claudiu Beznea wrote: > Hi Boris, s/Boris/Brian > > Thanks for your review. See below my answers. > > On 12.01.2018 20:35, Brian Norris wrote: >> Hi, >> >> On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: >>> Remove of_pwm_simple_xlate() and

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Claudiu Beznea
On 15.01.2018 10:41, Claudiu Beznea wrote: > Hi Boris, s/Boris/Brian > > Thanks for your review. See below my answers. > > On 12.01.2018 20:35, Brian Norris wrote: >> Hi, >> >> On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: >>> Remove of_pwm_simple_xlate() and

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Claudiu Beznea
Hi Boris, Thanks for your review. See below my answers. On 12.01.2018 20:35, Brian Norris wrote: > Hi, > > On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: >> Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions >> and add of_pwm_xlate() which is used in all cases

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Claudiu Beznea
Hi Boris, Thanks for your review. See below my answers. On 12.01.2018 20:35, Brian Norris wrote: > Hi, > > On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: >> Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions >> and add of_pwm_xlate() which is used in all cases

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-12 Thread Brian Norris
Hi, On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: > Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions > and add of_pwm_xlate() which is used in all cases no mather if the OF > bindings are with PWM flags or not. This should not affect the old > behavior since

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-12 Thread Brian Norris
Hi, On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: > Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions > and add of_pwm_xlate() which is used in all cases no mather if the OF > bindings are with PWM flags or not. This should not affect the old > behavior since