Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-06-13 Thread NeilBrown
On Wed, Jun 13 2018, James Simmons wrote: >> > With the cleanup of the libcfs SMP handling all UMP handling >> > was removed. In the process now various NULL pointers and >> > empty fields are return in the UMP case which causes lustre >> > to crash hard. Restore the proper UMP handling so Lustre

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-06-13 Thread NeilBrown
On Wed, Jun 13 2018, James Simmons wrote: >> > With the cleanup of the libcfs SMP handling all UMP handling >> > was removed. In the process now various NULL pointers and >> > empty fields are return in the UMP case which causes lustre >> > to crash hard. Restore the proper UMP handling so Lustre

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-06-13 Thread James Simmons
> > With the cleanup of the libcfs SMP handling all UMP handling > > was removed. In the process now various NULL pointers and > > empty fields are return in the UMP case which causes lustre > > to crash hard. Restore the proper UMP handling so Lustre can > > properly function. > > Can't we

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-06-13 Thread James Simmons
> > With the cleanup of the libcfs SMP handling all UMP handling > > was removed. In the process now various NULL pointers and > > empty fields are return in the UMP case which causes lustre > > to crash hard. Restore the proper UMP handling so Lustre can > > properly function. > > Can't we

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-30 Thread Dan Carpenter
On Tue, May 29, 2018 at 10:21:41AM -0400, James Simmons wrote: > @@ -208,20 +222,52 @@ void cfs_cpt_unset_nodemask(struct cfs_cpt_table *cptab, > void cfs_cpu_fini(void); > > #else /* !CONFIG_SMP */ > -struct cfs_cpt_table; > -#define cfs_cpt_tab ((struct cfs_cpt_table *)NULL) > > -static

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-30 Thread Dan Carpenter
On Tue, May 29, 2018 at 10:21:41AM -0400, James Simmons wrote: > @@ -208,20 +222,52 @@ void cfs_cpt_unset_nodemask(struct cfs_cpt_table *cptab, > void cfs_cpu_fini(void); > > #else /* !CONFIG_SMP */ > -struct cfs_cpt_table; > -#define cfs_cpt_tab ((struct cfs_cpt_table *)NULL) > > -static

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, James Simmons wrote: > With the cleanup of the libcfs SMP handling all UMP handling > was removed. In the process now various NULL pointers and > empty fields are return in the UMP case which causes lustre > to crash hard. Restore the proper UMP handling so Lustre can >

Re: [PATCH v2 01/25] staging: lustre: libcfs: restore UMP handling

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, James Simmons wrote: > With the cleanup of the libcfs SMP handling all UMP handling > was removed. In the process now various NULL pointers and > empty fields are return in the UMP case which causes lustre > to crash hard. Restore the proper UMP handling so Lustre can >