Re: [PATCH v2 07/10] KVM: Move MMU notifier's mmu_lock acquisition into common helper

2021-04-02 Thread Sean Christopherson
On Fri, Apr 02, 2021, Paolo Bonzini wrote: > On 02/04/21 02:56, Sean Christopherson wrote: > > + .handler= (void *)kvm_null_fn, > > + .on_lock= kvm_dec_notifier_count, > > + .flush_on_ret = true, > > Doesn't really matter since the handler is null,

Re: [PATCH v2 07/10] KVM: Move MMU notifier's mmu_lock acquisition into common helper

2021-04-02 Thread Paolo Bonzini
On 02/04/21 02:56, Sean Christopherson wrote: + .handler= (void *)kvm_null_fn, + .on_lock= kvm_dec_notifier_count, + .flush_on_ret = true, Doesn't really matter since the handler is null, but I think it's cleaner to have false here.