Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-21 Thread Mark Rutland
On Mon, Nov 20, 2017 at 12:35:49PM -0800, Sami Tolvanen wrote: > On Mon, Nov 20, 2017 at 02:47:20PM +, Mark Rutland wrote: > > However, we could instead check ld-version, produce a warning, and > > abort the build in such cases. > > I believe the version number of gold didn't change in

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-21 Thread Mark Rutland
On Mon, Nov 20, 2017 at 12:35:49PM -0800, Sami Tolvanen wrote: > On Mon, Nov 20, 2017 at 02:47:20PM +, Mark Rutland wrote: > > However, we could instead check ld-version, produce a warning, and > > abort the build in such cases. > > I believe the version number of gold didn't change in

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-20 Thread Sami Tolvanen
On Mon, Nov 20, 2017 at 02:47:20PM +, Mark Rutland wrote: > However, we could instead check ld-version, produce a warning, and > abort the build in such cases. I believe the version number of gold didn't change in binutils 2.28.1, where this was fixed, but we could certainly warn about older

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-20 Thread Sami Tolvanen
On Mon, Nov 20, 2017 at 02:47:20PM +, Mark Rutland wrote: > However, we could instead check ld-version, produce a warning, and > abort the build in such cases. I believe the version number of gold didn't change in binutils 2.28.1, where this was fixed, but we could certainly warn about older

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-20 Thread Mark Rutland
On Thu, Nov 16, 2017 at 08:35:49AM -0800, Sami Tolvanen wrote: > On Thu, Nov 16, 2017 at 11:47:23AM +, Will Deacon wrote: > > But if ARM64_ERRATUM_843419 is enabled, we'll go ahead and generate > > broken code? > > This bug has been fixed in all current versions of GNU gold, but of > course,

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-20 Thread Mark Rutland
On Thu, Nov 16, 2017 at 08:35:49AM -0800, Sami Tolvanen wrote: > On Thu, Nov 16, 2017 at 11:47:23AM +, Will Deacon wrote: > > But if ARM64_ERRATUM_843419 is enabled, we'll go ahead and generate > > broken code? > > This bug has been fixed in all current versions of GNU gold, but of > course,

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-16 Thread Sami Tolvanen
On Thu, Nov 16, 2017 at 11:47:23AM +, Will Deacon wrote: > But if ARM64_ERRATUM_843419 is enabled, we'll go ahead and generate > broken code? This bug has been fixed in all current versions of GNU gold, but of course, if someone is using a broken linker, it will generate broken code. We can't

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-16 Thread Sami Tolvanen
On Thu, Nov 16, 2017 at 11:47:23AM +, Will Deacon wrote: > But if ARM64_ERRATUM_843419 is enabled, we'll go ahead and generate > broken code? This bug has been fixed in all current versions of GNU gold, but of course, if someone is using a broken linker, it will generate broken code. We can't

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-16 Thread Will Deacon
On Wed, Nov 15, 2017 at 01:34:19PM -0800, Sami Tolvanen wrote: > Some versions of GNU gold are known to produce broken code with > --fix-cortex-a53-843419 as explained in this bug: > > https://sourceware.org/bugzilla/show_bug.cgi?id=21491 > > If ARM64_ERRATUM_843419 is disabled and we're using

Re: [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold

2017-11-16 Thread Will Deacon
On Wed, Nov 15, 2017 at 01:34:19PM -0800, Sami Tolvanen wrote: > Some versions of GNU gold are known to produce broken code with > --fix-cortex-a53-843419 as explained in this bug: > > https://sourceware.org/bugzilla/show_bug.cgi?id=21491 > > If ARM64_ERRATUM_843419 is disabled and we're using