Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-25 Thread Doug Anderson
Hi, On Mon, Sep 24, 2018 at 11:23 AM Trent Piepho wrote: > > On Mon, 2018-09-24 at 10:13 -0700, Doug Anderson wrote: > > IIUC previous suggestions about just naming it based on the first SoC > > was due to the difficulty of coming up with a good generic name to > > give something. For instance

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-25 Thread Doug Anderson
Hi, On Mon, Sep 24, 2018 at 11:23 AM Trent Piepho wrote: > > On Mon, 2018-09-24 at 10:13 -0700, Doug Anderson wrote: > > IIUC previous suggestions about just naming it based on the first SoC > > was due to the difficulty of coming up with a good generic name to > > give something. For instance

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-24 Thread Trent Piepho
On Mon, 2018-09-24 at 10:13 -0700, Doug Anderson wrote: > IIUC previous suggestions about just naming it based on the first SoC > was due to the difficulty of coming up with a good generic name to > give something. For instance you definitely wouldn't want to name it > "qcom-qspi-sdm8xx" because

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-24 Thread Trent Piepho
On Mon, 2018-09-24 at 10:13 -0700, Doug Anderson wrote: > IIUC previous suggestions about just naming it based on the first SoC > was due to the difficulty of coming up with a good generic name to > give something. For instance you definitely wouldn't want to name it > "qcom-qspi-sdm8xx" because

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-24 Thread Doug Anderson
Hi, On Sat, Sep 22, 2018 at 8:45 PM Stephen Boyd wrote: > > Quoting Mark Brown (2018-09-21 11:51:06) > > On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > > > > > It seems that everybody has misunderstood my email. Let me try to > > > clarify. > > > > > I'm not saying to replace

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-24 Thread Doug Anderson
Hi, On Sat, Sep 22, 2018 at 8:45 PM Stephen Boyd wrote: > > Quoting Mark Brown (2018-09-21 11:51:06) > > On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > > > > > It seems that everybody has misunderstood my email. Let me try to > > > clarify. > > > > > I'm not saying to replace

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-22 Thread Stephen Boyd
Quoting Mark Brown (2018-09-21 11:51:06) > On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > > > It seems that everybody has misunderstood my email. Let me try to > > clarify. > > > I'm not saying to replace the sdm845 qspi compatible with a generic one. > > I'm recommending that a

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-22 Thread Stephen Boyd
Quoting Mark Brown (2018-09-21 11:51:06) > On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > > > It seems that everybody has misunderstood my email. Let me try to > > clarify. > > > I'm not saying to replace the sdm845 qspi compatible with a generic one. > > I'm recommending that a

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Mark Brown
On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > It seems that everybody has misunderstood my email. Let me try to > clarify. > I'm not saying to replace the sdm845 qspi compatible with a generic one. > I'm recommending that a generic one is added in addition to the SoC > specific

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Mark Brown
On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > It seems that everybody has misunderstood my email. Let me try to > clarify. > I'm not saying to replace the sdm845 qspi compatible with a generic one. > I'm recommending that a generic one is added in addition to the SoC > specific

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Doug Anderson
Stephen On Fri, Sep 21, 2018 at 11:40 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2018-09-21 10:40:14) > > Hi, > > > > On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > > > > > Quoting Ryan Case (2018-09-20 15:40:54) > > > > diff --git > > > >

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Doug Anderson
Stephen On Fri, Sep 21, 2018 at 11:40 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2018-09-21 10:40:14) > > Hi, > > > > On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > > > > > Quoting Ryan Case (2018-09-20 15:40:54) > > > > diff --git > > > >

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Stephen Boyd
Quoting Doug Anderson (2018-09-21 10:40:14) > Hi, > > On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > > > Quoting Ryan Case (2018-09-20 15:40:54) > > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > > >

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Stephen Boyd
Quoting Doug Anderson (2018-09-21 10:40:14) > Hi, > > On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > > > Quoting Ryan Case (2018-09-20 15:40:54) > > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > > >

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Trent Piepho
On Fri, 2018-09-21 at 10:39 -0700, Mark Brown wrote: > On Fri, Sep 21, 2018 at 10:30:57AM -0700, Stephen Boyd wrote: > > Quoting Ryan Case (2018-09-20 15:40:54) > > > +Required properties: > > > +- compatible: Should contain: > > > + "qcom,sdm845-qspi" > > Does someone have a more

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Trent Piepho
On Fri, 2018-09-21 at 10:39 -0700, Mark Brown wrote: > On Fri, Sep 21, 2018 at 10:30:57AM -0700, Stephen Boyd wrote: > > Quoting Ryan Case (2018-09-20 15:40:54) > > > +Required properties: > > > +- compatible: Should contain: > > > + "qcom,sdm845-qspi" > > Does someone have a more

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Doug Anderson
Hi, On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > Quoting Ryan Case (2018-09-20 15:40:54) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > > b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > > new file mode 100644 > > index

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Doug Anderson
Hi, On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > Quoting Ryan Case (2018-09-20 15:40:54) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > > b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > > new file mode 100644 > > index

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Mark Brown
On Fri, Sep 21, 2018 at 10:30:57AM -0700, Stephen Boyd wrote: > Quoting Ryan Case (2018-09-20 15:40:54) > > +Required properties: > > +- compatible: Should contain: > > + "qcom,sdm845-qspi" > Does someone have a more generic compatible string that can be added > here to indicate

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Mark Brown
On Fri, Sep 21, 2018 at 10:30:57AM -0700, Stephen Boyd wrote: > Quoting Ryan Case (2018-09-20 15:40:54) > > +Required properties: > > +- compatible: Should contain: > > + "qcom,sdm845-qspi" > Does someone have a more generic compatible string that can be added > here to indicate

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Stephen Boyd
Quoting Ryan Case (2018-09-20 15:40:54) > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > new file mode 100644 > index ..ecfb1e2bd520 > --- /dev/null > +++

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Stephen Boyd
Quoting Ryan Case (2018-09-20 15:40:54) > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt > new file mode 100644 > index ..ecfb1e2bd520 > --- /dev/null > +++