Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread wlf
ck-chips.com; Allen Hsu (許嘉銘) <allen....@quantatw.com>; Stan Tsui <stant...@aopen.com> Subject: Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in Hi, On Wed, May 2, 2018 at 10:14 AM, wlf <w...@rock-chips.com> wrote: It's a good way to allocate an extra 3

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread wlf
...@linux.intel.com; Greg Kroah-Hartman ; Sergei Shtylyov ; Heiko Stübner ; LKML ; linux-...@vger.kernel.org; open list:ARM/Rockchip SoC... ; Frank Wang ; 黄涛 ; daniel.meng ; John Youn ; 王征增 ; z...@rock-chips.com; Allen Hsu (許嘉銘) ; Stan Tsui Subject: Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-04 Thread Doug Anderson
Hi, On Wed, May 2, 2018 at 10:14 AM, wlf wrote: > It's a good way to allocate an extra 3 bytes in the original bounce buffer > for this unaligned > issue, it's similar to the tailroom of sk_buff. However, just as you said, > we'd better find > the special cases where we need

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-04 Thread Doug Anderson
Hi, On Wed, May 2, 2018 at 10:14 AM, wlf wrote: > It's a good way to allocate an extra 3 bytes in the original bounce buffer > for this unaligned > issue, it's similar to the tailroom of sk_buff. However, just as you said, > we'd better find > the special cases where we need an oversized bounce

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-02 Thread wlf
Dear Doug, 在 2018年05月02日 12:33, Doug Anderson 写道: Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") rips out a lot of code to simply the allocation of aligned DMA. However, it

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-02 Thread wlf
Dear Doug, 在 2018年05月02日 12:33, Doug Anderson 写道: Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") rips out a lot of code to simply the allocation of aligned DMA. However, it also introduces a new

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-01 Thread Doug Anderson
Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in > a more supported way") rips out a lot of code to simply the > allocation of aligned DMA. However, it also introduces a new > issue when use isoc

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-01 Thread Doug Anderson
Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in > a more supported way") rips out a lot of code to simply the > allocation of aligned DMA. However, it also introduces a new > issue when use isoc split in transfer. > > In my