Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-01 Thread Guenter Roeck
On Mon, Oct 01, 2012 at 11:28:21PM -0400, Vivien Didelot wrote: > Hi Guenter, > Hi Vivien, [ ... ] > > > + } else { > > > + dev_dbg(>dev, "doesn't look like an " > > > + "ADS7828 compatible device\n"); > > > > WARNING:

Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-01 Thread Vivien Didelot
Hi Guenter, On Mon, 2012-10-01 at 18:20 -0700, Guenter Roeck wrote: > On Mon, Oct 01, 2012 at 07:16:24PM -0400, Vivien Didelot wrote: > > From: Guillaume Roguez > > > > The ADS7830 device is almost the same as the ADS7828, > > except that it does 8-bit sampling, instead of 12-bit. > > This

Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-01 Thread Guenter Roeck
On Mon, Oct 01, 2012 at 07:16:24PM -0400, Vivien Didelot wrote: > From: Guillaume Roguez > > The ADS7830 device is almost the same as the ADS7828, > except that it does 8-bit sampling, instead of 12-bit. > This patch extends the ads7828 driver to support this chip. > > Signed-off-by: Guillaume

Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-01 Thread Guenter Roeck
On Mon, Oct 01, 2012 at 07:16:24PM -0400, Vivien Didelot wrote: From: Guillaume Roguez guillaume.rog...@savoirfairelinux.com The ADS7830 device is almost the same as the ADS7828, except that it does 8-bit sampling, instead of 12-bit. This patch extends the ads7828 driver to support this

Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-01 Thread Vivien Didelot
Hi Guenter, On Mon, 2012-10-01 at 18:20 -0700, Guenter Roeck wrote: On Mon, Oct 01, 2012 at 07:16:24PM -0400, Vivien Didelot wrote: From: Guillaume Roguez guillaume.rog...@savoirfairelinux.com The ADS7830 device is almost the same as the ADS7828, except that it does 8-bit sampling,

Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-01 Thread Guenter Roeck
On Mon, Oct 01, 2012 at 11:28:21PM -0400, Vivien Didelot wrote: Hi Guenter, Hi Vivien, [ ... ] + } else { + dev_dbg(client-dev, doesn't look like an + ADS7828 compatible device\n); WARNING: quoted string