Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-23 Thread Joel Stanley
Hi Brendan, On Wed, Sep 21, 2016 at 3:35 AM, Brendan Higgins wrote: > First off, someone pointed out to me that the mapping that I used between > addresses and bus numbers is not actually valid for busses 8-14. > > This could be fixed by checking the offset, but I am

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-23 Thread Joel Stanley
Hi Brendan, On Wed, Sep 21, 2016 at 3:35 AM, Brendan Higgins wrote: > First off, someone pointed out to me that the mapping that I used between > addresses and bus numbers is not actually valid for busses 8-14. > > This could be fixed by checking the offset, but I am wondering if that is > the

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-20 Thread Brendan Higgins
To be clear, these bus numbers are defined as part of the hardware specification. I am not sure if that was clear before. On Tue, Sep 20, 2016 at 11:08 AM, Brendan Higgins wrote: > (sorry if you get a duplicate, I forgot to send plain text) > > First off, someone

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-20 Thread Brendan Higgins
To be clear, these bus numbers are defined as part of the hardware specification. I am not sure if that was clear before. On Tue, Sep 20, 2016 at 11:08 AM, Brendan Higgins wrote: > (sorry if you get a duplicate, I forgot to send plain text) > > First off, someone pointed out to me that the

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-20 Thread Brendan Higgins
(sorry if you get a duplicate, I forgot to send plain text) First off, someone pointed out to me that the mapping that I used between addresses and bus numbers is not actually valid for busses 8-14. This could be fixed by checking the offset, but I am wondering if that is the right way to do it.

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-20 Thread Brendan Higgins
(sorry if you get a duplicate, I forgot to send plain text) First off, someone pointed out to me that the mapping that I used between addresses and bus numbers is not actually valid for busses 8-14. This could be fixed by checking the offset, but I am wondering if that is the right way to do it.

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-19 Thread Brendan Higgins
Addressed in v3. Thanks! On Mon, Sep 19, 2016 at 2:35 PM, Rob Herring wrote: > On Fri, Sep 09, 2016 at 06:55:51PM -0700, Brendan Higgins wrote: >> Added device tree binding documentation for Aspeed I2C controller and >> busses. >> >> Signed-off-by: Brendan Higgins

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-19 Thread Brendan Higgins
Addressed in v3. Thanks! On Mon, Sep 19, 2016 at 2:35 PM, Rob Herring wrote: > On Fri, Sep 09, 2016 at 06:55:51PM -0700, Brendan Higgins wrote: >> Added device tree binding documentation for Aspeed I2C controller and >> busses. >> >> Signed-off-by: Brendan Higgins >> --- >> Changes for v2: >>

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-19 Thread Rob Herring
On Fri, Sep 09, 2016 at 06:55:51PM -0700, Brendan Higgins wrote: > Added device tree binding documentation for Aspeed I2C controller and > busses. > > Signed-off-by: Brendan Higgins > --- > Changes for v2: > - None > --- > .../devicetree/bindings/i2c/i2c-aspeed.txt

Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver

2016-09-19 Thread Rob Herring
On Fri, Sep 09, 2016 at 06:55:51PM -0700, Brendan Higgins wrote: > Added device tree binding documentation for Aspeed I2C controller and > busses. > > Signed-off-by: Brendan Higgins > --- > Changes for v2: > - None > --- > .../devicetree/bindings/i2c/i2c-aspeed.txt | 63 >