Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-17 Thread Andreas Klinger
Hi Jonathan, [...] > >> For the range, it's an interesting one. Again the term range could > >> mean too many things within the wider ABI. We need to make it more > >> specific. > >> > >> Actually reading the datasheet, I think this is fundamentally about the > >> maximum sampling frequency

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-17 Thread Andreas Klinger
Hi Jonathan, [...] > >> For the range, it's an interesting one. Again the term range could > >> mean too many things within the wider ABI. We need to make it more > >> specific. > >> > >> Actually reading the datasheet, I think this is fundamentally about the > >> maximum sampling frequency

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-15 Thread Jonathan Cameron
On 14/01/17 17:48, Andreas Klinger wrote: > Hi Jonathan, > > see comments below. > > Andreas > > > Jonathan Cameron schrieb am Sat, 14. Jan 12:17: >> On 10/01/17 18:48, Andreas Klinger wrote: >>> This is the IIO driver for devantech srf08 ultrasonic ranger which can be >>>

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-15 Thread Jonathan Cameron
On 14/01/17 17:48, Andreas Klinger wrote: > Hi Jonathan, > > see comments below. > > Andreas > > > Jonathan Cameron schrieb am Sat, 14. Jan 12:17: >> On 10/01/17 18:48, Andreas Klinger wrote: >>> This is the IIO driver for devantech srf08 ultrasonic ranger which can be >>> used to measure the

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-15 Thread Lars-Peter Clausen
On 01/10/2017 07:48 PM, Andreas Klinger wrote: [...] > + indio_dev->name = dev_name(>dev); The name is supposed to be the type of the device, e.g. part name, not the name of parent device instance. E.g. "srf08" in this case.

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-15 Thread Lars-Peter Clausen
On 01/10/2017 07:48 PM, Andreas Klinger wrote: [...] > + indio_dev->name = dev_name(>dev); The name is supposed to be the type of the device, e.g. part name, not the name of parent device instance. E.g. "srf08" in this case.

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-14 Thread Andreas Klinger
Hi Jonathan, see comments below. Andreas Jonathan Cameron schrieb am Sat, 14. Jan 12:17: > On 10/01/17 18:48, Andreas Klinger wrote: > > This is the IIO driver for devantech srf08 ultrasonic ranger which can be > > used to measure the distances to an object. > > > > The

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-14 Thread Andreas Klinger
Hi Jonathan, see comments below. Andreas Jonathan Cameron schrieb am Sat, 14. Jan 12:17: > On 10/01/17 18:48, Andreas Klinger wrote: > > This is the IIO driver for devantech srf08 ultrasonic ranger which can be > > used to measure the distances to an object. > > > > The sensor supports I2C

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-14 Thread Jonathan Cameron
On 10/01/17 18:48, Andreas Klinger wrote: > This is the IIO driver for devantech srf08 ultrasonic ranger which can be > used to measure the distances to an object. > > The sensor supports I2C with some registers. > > Supported Features include: > - read the distance in ranging mode in

Re: [PATCH v2 2/2] iio: distance: srf08: add IIO driver for us ranger

2017-01-14 Thread Jonathan Cameron
On 10/01/17 18:48, Andreas Klinger wrote: > This is the IIO driver for devantech srf08 ultrasonic ranger which can be > used to measure the distances to an object. > > The sensor supports I2C with some registers. > > Supported Features include: > - read the distance in ranging mode in