Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-06-15 Thread Ulf Hansson
On Mon, 15 Jun 2020 at 13:49, Mark Brown wrote: > > On Mon, Jun 15, 2020 at 12:27:23PM +0200, Ulf Hansson wrote: > > > eMMC is not only about voltage levels, but also about enable/disable > > of the regulator(s). > > > More precisely, one needs to follow the steps specified in the eMMC > > spec,

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 12:27:23PM +0200, Ulf Hansson wrote: > eMMC is not only about voltage levels, but also about enable/disable > of the regulator(s). > More precisely, one needs to follow the steps specified in the eMMC > spec, when disabling the regulator(s). > In other words, the mmc

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-06-15 Thread Ulf Hansson
On Tue, 9 Jun 2020 at 12:51, Mark Brown wrote: > > On Mon, Jun 08, 2020 at 08:16:44PM -0700, Saravana Kannan wrote: > > On Mon, Jun 1, 2020 at 10:23 AM Mark Brown wrote: > > > > This is I think the first time anyone has suggested that this is likely > > > to be an issue - the previous concerns

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-06-09 Thread Mark Brown
On Mon, Jun 08, 2020 at 08:16:44PM -0700, Saravana Kannan wrote: > On Mon, Jun 1, 2020 at 10:23 AM Mark Brown wrote: > > This is I think the first time anyone has suggested that this is likely > > to be an issue - the previous concerns have all been about screens > > glitching. > Looks like we

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-06-08 Thread Saravana Kannan
On Mon, Jun 1, 2020 at 10:23 AM Mark Brown wrote: > > On Fri, May 29, 2020 at 07:39:33PM -0700, Saravana Kannan wrote: > > On Fri, May 29, 2020 at 6:00 AM Mark Brown wrote: > > > On Thu, May 28, 2020 at 12:06:10PM -0700, Saravana Kannan wrote: > > > > > especially important for regulators that

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-06-01 Thread Mark Brown
On Fri, May 29, 2020 at 07:39:33PM -0700, Saravana Kannan wrote: > On Fri, May 29, 2020 at 6:00 AM Mark Brown wrote: > > On Thu, May 28, 2020 at 12:06:10PM -0700, Saravana Kannan wrote: > > > especially important for regulators that might be powering more than one > > > consumer. Otherwise, when

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-05-29 Thread Saravana Kannan
On Fri, May 29, 2020 at 6:00 AM Mark Brown wrote: > > On Thu, May 28, 2020 at 12:06:10PM -0700, Saravana Kannan wrote: > > When a regulator is left on by the bootloader or anything else before > > the kernel starts (let's call this a "boot on" regulator), we need to > > keep it on till all the

Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks

2020-05-29 Thread Mark Brown
On Thu, May 28, 2020 at 12:06:10PM -0700, Saravana Kannan wrote: > When a regulator is left on by the bootloader or anything else before > the kernel starts (let's call this a "boot on" regulator), we need to > keep it on till all the consumers of the regulator have probed. This is We we don't in