Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 26/06/15 13:04, majun (F) wrote: > > > 在 2015/6/26 18:40, Marc Zyngier 写道: >> >> My opinion is that we need to be able to lookup the domain from the core >> code without any of these hacks, and this is what I'm working on at the >> moment. There is no way external code will be allowed to mess

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread majun (F)
在 2015/6/26 18:40, Marc Zyngier 写道: > > My opinion is that we need to be able to lookup the domain from the core > code without any of these hacks, and this is what I'm working on at the > moment. There is no way external code will be allowed to mess with the > internals of the ITS. > > For

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 26/06/15 11:28, majun (F) wrote: > > Hi Marc: > > 在 2015/6/26 16:44, Marc Zyngier 写道: >> >> You can then keep your MBI stuff in a separate file, and call into >> its_msi_prepare. >> > Thanks for your good suggestion! > I have two questions: > > Question 1: > > I found the ‘its_msi_preapare

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread majun (F)
Hi Marc: 在 2015/6/26 16:44, Marc Zyngier 写道: > > You can then keep your MBI stuff in a separate file, and call into > its_msi_prepare. > Thanks for your good suggestion! I have two questions: Question 1: I found the ‘its_msi_preapare ' defined without static. So,I guess you mean I can call

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 23/06/15 10:29, Thomas Gleixner wrote: > On Tue, 23 Jun 2015, majun (F) wrote: >> 在 2015/6/19 7:52, Thomas Gleixner 写道: >>> On Mon, 15 Jun 2015, majun (F) wrote: 在 2015/6/12 18:48, Thomas Gleixner 写道: > Can you please provide a proper description of this mbigen chip and > explain

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 26/06/15 07:31, majun (F) wrote: > Hi Thomas: > > 在 2015/6/12 10:49, Ma Jun 写道: > >> +static int its_mbigen_prepare(struct irq_domain *domain, struct mbi_desc >> *desc, >> +int hwirq, >> struct mbi_alloc_info *arg) >> +{ >> +

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread majun (F)
Hi Thomas: 在 2015/6/12 10:49, Ma Jun 写道: > +static int its_mbigen_prepare(struct irq_domain *domain, struct mbi_desc > *desc, > + int hwirq, > struct mbi_alloc_info *arg) > +{ > + struct its_node *its = domain->parent->host_data;

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread majun (F)
Hi Thomas: 在 2015/6/12 10:49, Ma Jun 写道: +static int its_mbigen_prepare(struct irq_domain *domain, struct mbi_desc *desc, + int hwirq, struct mbi_alloc_info *arg) +{ + struct its_node *its = domain-parent-host_data; +

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 26/06/15 07:31, majun (F) wrote: Hi Thomas: 在 2015/6/12 10:49, Ma Jun 写道: +static int its_mbigen_prepare(struct irq_domain *domain, struct mbi_desc *desc, +int hwirq, struct mbi_alloc_info *arg) +{ +struct its_node

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 23/06/15 10:29, Thomas Gleixner wrote: On Tue, 23 Jun 2015, majun (F) wrote: 在 2015/6/19 7:52, Thomas Gleixner 写道: On Mon, 15 Jun 2015, majun (F) wrote: 在 2015/6/12 18:48, Thomas Gleixner 写道: Can you please provide a proper description of this mbigen chip and explain WHY you think that it

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread majun (F)
在 2015/6/26 18:40, Marc Zyngier 写道: My opinion is that we need to be able to lookup the domain from the core code without any of these hacks, and this is what I'm working on at the moment. There is no way external code will be allowed to mess with the internals of the ITS. For the time

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 26/06/15 11:28, majun (F) wrote: Hi Marc: 在 2015/6/26 16:44, Marc Zyngier 写道: You can then keep your MBI stuff in a separate file, and call into its_msi_prepare. Thanks for your good suggestion! I have two questions: Question 1: I found the ‘its_msi_preapare ' defined without

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread majun (F)
Hi Marc: 在 2015/6/26 16:44, Marc Zyngier 写道: You can then keep your MBI stuff in a separate file, and call into its_msi_prepare. Thanks for your good suggestion! I have two questions: Question 1: I found the ‘its_msi_preapare ' defined without static. So,I guess you mean I can call this

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-26 Thread Marc Zyngier
On 26/06/15 13:04, majun (F) wrote: 在 2015/6/26 18:40, Marc Zyngier 写道: My opinion is that we need to be able to lookup the domain from the core code without any of these hacks, and this is what I'm working on at the moment. There is no way external code will be allowed to mess with the

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-23 Thread Thomas Gleixner
On Tue, 23 Jun 2015, majun (F) wrote: > 在 2015/6/19 7:52, Thomas Gleixner 写道: > > On Mon, 15 Jun 2015, majun (F) wrote: > >> 在 2015/6/12 18:48, Thomas Gleixner 写道: > >>> Can you please provide a proper description of this mbigen chip and > >>> explain WHY you think that it needs all this special

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-23 Thread majun (F)
在 2015/6/19 7:52, Thomas Gleixner 写道: > On Mon, 15 Jun 2015, majun (F) wrote: >> 在 2015/6/12 18:48, Thomas Gleixner 写道: >>> Can you please provide a proper description of this mbigen chip and >>> explain WHY you think that it needs all this special hackery? > > You carefully avoided to provide

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-23 Thread Thomas Gleixner
On Tue, 23 Jun 2015, majun (F) wrote: 在 2015/6/19 7:52, Thomas Gleixner 写道: On Mon, 15 Jun 2015, majun (F) wrote: 在 2015/6/12 18:48, Thomas Gleixner 写道: Can you please provide a proper description of this mbigen chip and explain WHY you think that it needs all this special hackery?

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-23 Thread majun (F)
在 2015/6/19 7:52, Thomas Gleixner 写道: On Mon, 15 Jun 2015, majun (F) wrote: 在 2015/6/12 18:48, Thomas Gleixner 写道: Can you please provide a proper description of this mbigen chip and explain WHY you think that it needs all this special hackery? You carefully avoided to provide a proper

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-18 Thread Thomas Gleixner
On Mon, 15 Jun 2015, majun (F) wrote: > 在 2015/6/12 18:48, Thomas Gleixner 写道: > > Can you please provide a proper description of this mbigen chip and > > explain WHY you think that it needs all this special hackery? You carefully avoided to provide a proper description of this mbigen chip and

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-18 Thread Thomas Gleixner
On Mon, 15 Jun 2015, majun (F) wrote: 在 2015/6/12 18:48, Thomas Gleixner 写道: Can you please provide a proper description of this mbigen chip and explain WHY you think that it needs all this special hackery? You carefully avoided to provide a proper description of this mbigen chip and how it

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-15 Thread majun (F)
在 2015/6/12 18:48, Thomas Gleixner 写道: > On Fri, 12 Jun 2015, Ma Jun wrote: > >> This patch is applied to support the mbigen interrupt. >> >> As a kind of MSI interrupt controller, the mbigen is used as a child >> domain of ITS domain just like PCI devices. >> So the arm-gic-v3-its and related

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-15 Thread majun (F)
在 2015/6/12 18:48, Thomas Gleixner 写道: On Fri, 12 Jun 2015, Ma Jun wrote: This patch is applied to support the mbigen interrupt. As a kind of MSI interrupt controller, the mbigen is used as a child domain of ITS domain just like PCI devices. So the arm-gic-v3-its and related files are

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-12 Thread Thomas Gleixner
On Fri, 12 Jun 2015, Ma Jun wrote: > This patch is applied to support the mbigen interrupt. > > As a kind of MSI interrupt controller, the mbigen is used as a child > domain of ITS domain just like PCI devices. > So the arm-gic-v3-its and related files are changed. > > The chip.c is also

Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt

2015-06-12 Thread Thomas Gleixner
On Fri, 12 Jun 2015, Ma Jun wrote: This patch is applied to support the mbigen interrupt. As a kind of MSI interrupt controller, the mbigen is used as a child domain of ITS domain just like PCI devices. So the arm-gic-v3-its and related files are changed. The chip.c is also changed to