Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

2015-11-19 Thread hejianet
Thanks, I will add it in next verison B.R. Justin 在 11/19/15 4:40 PM, xinhui 写道: hi, jia Nice patch. But I have one minor question. see inline comments. On 2015/11/19 14:48, Jia He wrote: This patch introduces 2 lightweight bit api. all_bit_is_zero return 1 if the bit string is all zero.

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

2015-11-19 Thread yalin wang
> On Nov 19, 2015, at 14:48, Jia He wrote: > > why not use memcmp() to compare with 0x000 or 0x ? memcmp() have better performance on some platforms . Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

2015-11-19 Thread xinhui
hi, jia Nice patch. But I have one minor question. see inline comments. On 2015/11/19 14:48, Jia He wrote: This patch introduces 2 lightweight bit api. all_bit_is_zero return 1 if the bit string is all zero. The addr is the start address, the size is the bit size of the bit string.

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

2015-11-19 Thread xinhui
hi, jia Nice patch. But I have one minor question. see inline comments. On 2015/11/19 14:48, Jia He wrote: This patch introduces 2 lightweight bit api. all_bit_is_zero return 1 if the bit string is all zero. The addr is the start address, the size is the bit size of the bit string.

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

2015-11-19 Thread yalin wang
> On Nov 19, 2015, at 14:48, Jia He wrote: > > why not use memcmp() to compare with 0x000 or 0x ? memcmp() have better performance on some platforms . Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

2015-11-19 Thread hejianet
Thanks, I will add it in next verison B.R. Justin 在 11/19/15 4:40 PM, xinhui 写道: hi, jia Nice patch. But I have one minor question. see inline comments. On 2015/11/19 14:48, Jia He wrote: This patch introduces 2 lightweight bit api. all_bit_is_zero return 1 if the bit string is all zero.