Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski ---

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski --- .../devicetree/bindings/regulator/lp872x.txt | 1

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

On 2/13/2016 3:25 AM, Paul Kocialkowski wrote: > >+ > >+ /* Always set enable GPIO high. */ > >+ ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN"); > >+ if (ret) { > >+ dev_err(lp->dev, "gpio request err: %d\n", ret); > >+

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

On 2/13/2016 3:25 AM, Paul Kocialkowski wrote: > >+ > >+ /* Always set enable GPIO high. */ > >+ ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN"); > >+ if (ret) { > >+ dev_err(lp->dev, "gpio request err: %d\n", ret); > >+

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

Hi, Le vendredi 12 février 2016 à 09:14 +0900, Kim, Milo a écrit : > Thanks for the patch. Please see my comments below. Thanks for the review! > On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: > > LP872x regulators are made active via the EN pin, which might be hooked to a > > GPIO. This adds

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

Hi, Le vendredi 12 février 2016 à 09:14 +0900, Kim, Milo a écrit : > Thanks for the patch. Please see my comments below. Thanks for the review! > On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: > > LP872x regulators are made active via the EN pin, which might be hooked to a > > GPIO. This adds

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

Hi Paul, Thanks for the patch. Please see my comments below. On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

Hi Paul, Thanks for the patch. Please see my comments below. On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

On Fri, Feb 05, 2016 at 07:42:19PM +0100, Paul Kocialkowski wrote: > LP872x regulators are made active via the EN pin, which might be hooked to a > GPIO. This adds support for driving the GPIO high when the driver is in use. > > Signed-off-by: Paul Kocialkowski > --- >

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

On Fri, Feb 05, 2016 at 07:42:19PM +0100, Paul Kocialkowski wrote: > LP872x regulators are made active via the EN pin, which might be hooked to a > GPIO. This adds support for driving the GPIO high when the driver is in use. > > Signed-off-by: Paul Kocialkowski > --- >