Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-29 Thread h...@lst.de
On Sat, Aug 29, 2015 at 04:04:58AM +, Williams, Dan J wrote: > On Fri, 2015-08-28 at 15:48 -0600, Toshi Kani wrote: > > On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: > > > On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > > > > On Wed, 2015-08-26 at 21:34 +, Williams, Dan J

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-29 Thread h...@lst.de
On Sat, Aug 29, 2015 at 04:04:58AM +, Williams, Dan J wrote: On Fri, 2015-08-28 at 15:48 -0600, Toshi Kani wrote: On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-08-26 at 21:34 +, Williams,

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Williams, Dan J
On Fri, 2015-08-28 at 15:48 -0600, Toshi Kani wrote: > On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: > > On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > > > On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: > > [..] > > > > -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > > > >

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Toshi Kani
On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: > On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > > On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: > [..] > > > -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > > > Should it be better to do: > > > > #else /*

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Dan Williams
On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani wrote: > On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: [..] >> -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > Should it be better to do: > > #else /* !CONFIG_ARCH_HAS_PMEM_API */ > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT > > so that you can

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Toshi Kani
On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: > On Wed, 2015-08-26 at 14:41 +0200, Christoph Hellwig wrote: > > I like the intent behind this, but not the implementation. > > > > I think the right approach is to keep the defaults in linux/pmem.h > > and simply not set

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Ross Zwisler
On Wed, Aug 26, 2015 at 09:34:20PM +, Williams, Dan J wrote: > On Wed, 2015-08-26 at 14:41 +0200, Christoph Hellwig wrote: > > I like the intent behind this, but not the implementation. > > > > I think the right approach is to keep the defaults in linux/pmem.h > > and simply not set

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Williams, Dan J
On Fri, 2015-08-28 at 15:48 -0600, Toshi Kani wrote: On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: [..] -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Toshi Kani
On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: On Wed, 2015-08-26 at 14:41 +0200, Christoph Hellwig wrote: I like the intent behind this, but not the implementation. I think the right approach is to keep the defaults in linux/pmem.h and simply not set CONFIG_ARCH_HAS_PMEM_API

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Toshi Kani
On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: [..] -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB Should it be better to do: #else /*

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Dan Williams
On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-08-26 at 21:34 +, Williams, Dan J wrote: [..] -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB Should it be better to do: #else /* !CONFIG_ARCH_HAS_PMEM_API */ #define ARCH_MEMREMAP_PMEM MEMREMAP_WT so that you

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-28 Thread Ross Zwisler
On Wed, Aug 26, 2015 at 09:34:20PM +, Williams, Dan J wrote: On Wed, 2015-08-26 at 14:41 +0200, Christoph Hellwig wrote: I like the intent behind this, but not the implementation. I think the right approach is to keep the defaults in linux/pmem.h and simply not set

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-27 Thread h...@lst.de
This looks fine to me, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-27 Thread h...@lst.de
This looks fine to me, Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-26 Thread Williams, Dan J
On Wed, 2015-08-26 at 14:41 +0200, Christoph Hellwig wrote: > I like the intent behind this, but not the implementation. > > I think the right approach is to keep the defaults in linux/pmem.h > and simply not set CONFIG_ARCH_HAS_PMEM_API for x86-32. Yes, that makes things much cleaner. Revised

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-26 Thread Christoph Hellwig
I like the intent behind this, but not the implementation. I think the right approach is to keep the defaults in linux/pmem.h and simply not set CONFIG_ARCH_HAS_PMEM_API for x86-32. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-26 Thread Williams, Dan J
On Wed, 2015-08-26 at 14:41 +0200, Christoph Hellwig wrote: I like the intent behind this, but not the implementation. I think the right approach is to keep the defaults in linux/pmem.h and simply not set CONFIG_ARCH_HAS_PMEM_API for x86-32. Yes, that makes things much cleaner. Revised

Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

2015-08-26 Thread Christoph Hellwig
I like the intent behind this, but not the implementation. I think the right approach is to keep the defaults in linux/pmem.h and simply not set CONFIG_ARCH_HAS_PMEM_API for x86-32. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to