Re: [PATCH v23 01/15] mm: Introduce Data Access MONitor (DAMON)

2020-12-23 Thread SeongJae Park
On Wed, 23 Dec 2020 14:49:57 -0800 Shakeel Butt wrote: > On Wed, Dec 23, 2020 at 8:34 AM SeongJae Park wrote: > [snip] > > > Overall the patch looks good to me. Two concerns I have are if we > > > should damon_callback here or with the real user and the regions part > > > of primitive

Re: [PATCH v23 01/15] mm: Introduce Data Access MONitor (DAMON)

2020-12-23 Thread Shakeel Butt
On Wed, Dec 23, 2020 at 8:34 AM SeongJae Park wrote: [snip] > > Overall the patch looks good to me. Two concerns I have are if we > > should damon_callback here or with the real user and the regions part > > of primitive abstraction. For the first one, I don't have any strong > > opinion but for

Re: [PATCH v23 01/15] mm: Introduce Data Access MONitor (DAMON)

2020-12-23 Thread SeongJae Park
Thanks for the valuable comments, Shakeel! On Wed, 23 Dec 2020 07:11:12 -0800 Shakeel Butt wrote: > First I would like you to prune your To/CC list. I will remove people not directly related with this work and didn't comment to this series yet. > > On Tue, Dec 15, 2020 at 3:56 AM SeongJae

Re: [PATCH v23 01/15] mm: Introduce Data Access MONitor (DAMON)

2020-12-23 Thread Shakeel Butt
First I would like you to prune your To/CC list. On Tue, Dec 15, 2020 at 3:56 AM SeongJae Park wrote: > > From: SeongJae Park > > DAMON is a data access monitoring framework for the Linux kernel. The > core mechanisms of DAMON make it > > - accurate (the monitoring output is useful enough for