Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Andrey Konovalov
On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack > instrumentation, but we should only need one config, so that we remove > CONFIG_KASAN_STACK_ENABLE and make CONFIG_KASAN_STACK workable. see [1]. > > When enable KASAN

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Andrey Konovalov
On Mon, Jan 11, 2021 at 8:11 PM Nathan Chancellor wrote: > > On Mon, Jan 11, 2021 at 08:03:29PM +0100, Andrey Konovalov wrote: > > On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor > > wrote: > > > > > > > > -config KASAN_STACK_ENABLE > > > > > +config KASAN_STACK > > > > > bool "Enable

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 08:03:29PM +0100, Andrey Konovalov wrote: > On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor > wrote: > > > > > > -config KASAN_STACK_ENABLE > > > > +config KASAN_STACK > > > > bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && > > > > !COMPILE_TEST >

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Andrey Konovalov
On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor wrote: > > > > -config KASAN_STACK_ENABLE > > > +config KASAN_STACK > > > bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && > > > !COMPILE_TEST > > > > Does this syntax mean that KASAN_STACK is only present for > >

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 06:49:37PM +0100, Andrey Konovalov wrote: > On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > > > CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack > > instrumentation, but we should only need one config, so that we remove > >

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Andrey Konovalov
On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack > instrumentation, but we should only need one config, so that we remove > CONFIG_KASAN_STACK_ENABLE and make CONFIG_KASAN_STACK workable. see [1]. > > When enable KASAN

Re: [PATCH v3] kasan: remove redundant config option

2021-01-11 Thread Andrey Konovalov
On Fri, Jan 8, 2021 at 9:31 PM Arnd Bergmann wrote: > > On Fri, Jan 8, 2021 at 7:56 PM Andrey Konovalov wrote: > > On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > > > @@ -2,6 +2,12 @@ > > > CFLAGS_KASAN_NOSANITIZE := -fno-builtin > > > KASAN_SHADOW_OFFSET ?= $(CONFIG_KASAN_SHADOW_OFFSET)

Re: [PATCH v3] kasan: remove redundant config option

2021-01-08 Thread Arnd Bergmann
On Fri, Jan 8, 2021 at 7:56 PM Andrey Konovalov wrote: > On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > @@ -2,6 +2,12 @@ > > CFLAGS_KASAN_NOSANITIZE := -fno-builtin > > KASAN_SHADOW_OFFSET ?= $(CONFIG_KASAN_SHADOW_OFFSET) > > > > +ifdef CONFIG_KASAN_STACK > > + stack_enable := 1 >

Re: [PATCH v3] kasan: remove redundant config option

2021-01-08 Thread Andrey Konovalov
On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack > instrumentation, but we should only need one config, so that we remove > CONFIG_KASAN_STACK_ENABLE and make CONFIG_KASAN_STACK workable. see [1]. > > When enable KASAN

Re: [PATCH v3] kasan: remove redundant config option

2021-01-07 Thread Nathan Chancellor
On Fri, Jan 08, 2021 at 12:09:40PM +0800, Walter Wu wrote: > CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack > instrumentation, but we should only need one config, so that we remove > CONFIG_KASAN_STACK_ENABLE and make CONFIG_KASAN_STACK workable. see [1]. > > When enable