Re: [PATCH v3 0/4] PINCTRL: Mediatek pinctrl driver for mt2712

2018-03-07 Thread Sean Wang
Hi, Zhiyong you should checkpatch every patch before sending them out because I saw tons of check messages like below result for scanning v3 3/4 CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #152: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:85: +static int

Re: [PATCH v3 0/4] PINCTRL: Mediatek pinctrl driver for mt2712

2018-03-07 Thread Sean Wang
Hi, Zhiyong you should checkpatch every patch before sending them out because I saw tons of check messages like below result for scanning v3 3/4 CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #152: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:85: +static int