Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-05-06 Thread Miroslav Benes
On Fri, 3 May 2019, Joe Lawrence wrote: > On Tue, Apr 16, 2019 at 01:37:13PM +0200, Miroslav Benes wrote: > > > > [ ... snip ... ] > > > > Quick look, but it seems quite similar to the problem we had with > > apply_alternatives(). See arch/x86/kernel/livepatch.c and the commit which > >

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-05-03 Thread Joe Lawrence
On Tue, Apr 16, 2019 at 01:37:13PM +0200, Miroslav Benes wrote: > > [ ... snip ... ] > > Quick look, but it seems quite similar to the problem we had with > apply_alternatives(). See arch/x86/kernel/livepatch.c and the commit which > introduced it. That was an interesting diversion :) I think I

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-24 Thread Joe Lawrence
On 4/24/19 3:13 PM, Joao Moreira wrote: Future Work --- I don't see an easy way to support multiple homonym symbols with unique values in the current livepatch module Elf format. The only solutions that come to mind right now include renaming homonym symbols somehow to retain the

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-24 Thread Josh Poimboeuf
On Wed, Apr 24, 2019 at 04:13:59PM -0300, Joao Moreira wrote: > > > Future Work > > > --- > > > > > > I don't see an easy way to support multiple homonym > > > symbols with unique values in the current livepatch module > > > Elf format. The only solutions that come to mind right now

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-24 Thread Joao Moreira
On 4/24/19 3:19 PM, Miroslav Benes wrote: [...] Result: a small tweak to sympos_sanity_check() to relax its symbol uniqueness verification: allow for duplicate instances. Now it will only complain when a supplied symbol references the same but a different . diff --git

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-24 Thread Miroslav Benes
[...] > Result: a small tweak to sympos_sanity_check() to relax its symbol > uniqueness verification: allow for duplicate > instances. Now it will only complain when a supplied symbol references > the same but a different . > > diff --git a/scripts/livepatch/klp-convert.c

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-17 Thread Joe Lawrence
On Wed, Apr 10, 2019 at 11:50:49AM -0400, Joe Lawrence wrote: > > [ ... snip ... ] > > TODO > > > There are a few outstanding items that I came across while reviewing v2, > but as changes started accumulating, it made sense to defer those to a > later version. I'll reply to this thread

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-16 Thread Miroslav Benes
On Tue, 16 Apr 2019, Joe Lawrence wrote: > On 4/10/19 11:50 AM, Joe Lawrence wrote: > > Hi folks, > > > > This is the third installment of the klp-convert tool for generating and > > processing livepatch symbols for livepatch module builds. For those > > following along at home, archive links

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-16 Thread Joe Lawrence
On 4/10/19 11:50 AM, Joe Lawrence wrote: Hi folks, This is the third installment of the klp-convert tool for generating and processing livepatch symbols for livepatch module builds. For those following along at home, archive links to previous versions: RFC:

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-16 Thread Joe Lawrence
On 4/16/19 1:24 AM, Balbir Singh wrote: Could we get some details with examples or a sample, sorry I might be dense and missing simple information. The problem being solved is not clear to me from the changelog. Hi Balbir, I see that Miroslav has already pointed to documentation, samples

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-16 Thread Miroslav Benes
[...] > Current behavior > > > Not good. The livepatch successfully builds but crashes on load: > > % insmod lib/livepatch/test_klp_static_keys_mod.ko > % insmod lib/livepatch/test_klp_static_keys.ko > > BUG: unable to handle kernel NULL pointer dereference at

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-16 Thread Miroslav Benes
On Tue, 16 Apr 2019, Balbir Singh wrote: > On Wed, Apr 10, 2019 at 11:50:49AM -0400, Joe Lawrence wrote: > > Hi folks, > > > > This is the third installment of the klp-convert tool for generating and > > processing livepatch symbols for livepatch module builds. For those > > following along at

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-15 Thread Balbir Singh
On Wed, Apr 10, 2019 at 11:50:49AM -0400, Joe Lawrence wrote: > Hi folks, > > This is the third installment of the klp-convert tool for generating and > processing livepatch symbols for livepatch module builds. For those > following along at home, archive links to previous versions: > > RFC: >

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-04-12 Thread Joe Lawrence
On Wed, Apr 10, 2019 at 11:50:49AM -0400, Joe Lawrence wrote: > Hi folks, > > This is the third installment of the klp-convert tool for generating and > processing livepatch symbols for livepatch module builds. For those > following along at home, archive links to previous versions: > > RFC: >