Re: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor()

2021-04-02 Thread Christoph Hellwig
> + if (!pmd) > + return dax_load_hole(xas, mapping, , vmf); > + else > + return dax_pmd_load_hole(xas, vmf, iomap, ); > + if (pmd) > + return vmf_insert_pfn_pmd(vmf, pfn, write); > + if (write) > +

RE: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor()

2021-03-30 Thread ruansy.f...@fujitsu.com
> -Original Message- > From: Ritesh Harjani > Sent: Tuesday, March 23, 2021 11:48 PM > Subject: Re: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor() > > > > On 3/19/21 7:22 AM, Shiyang Ruan wrote: > > The core logic in the two dax page fault func

Re: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor()

2021-03-23 Thread Ritesh Harjani
On 3/19/21 7:22 AM, Shiyang Ruan wrote: The core logic in the two dax page fault functions is similar. So, move the logic into a common helper function. Also, to facilitate the addition of new features, such as CoW, switch-case is no longer used to handle different iomap types.