Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-13 Thread John Hubbard
On 3/13/19 7:49 AM, Ira Weiny wrote: On Tue, Mar 12, 2019 at 05:38:55PM -0700, John Hubbard wrote: On 3/12/19 8:30 AM, Ira Weiny wrote: On Wed, Mar 06, 2019 at 03:54:55PM -0800, john.hubb...@gmail.com wrote: From: John Hubbard Introduces put_user_page(), which simply calls put_page(). This

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-13 Thread Ira Weiny
On Tue, Mar 12, 2019 at 05:38:55PM -0700, John Hubbard wrote: > On 3/12/19 8:30 AM, Ira Weiny wrote: > > On Wed, Mar 06, 2019 at 03:54:55PM -0800, john.hubb...@gmail.com wrote: > > > From: John Hubbard > > > > > > Introduces put_user_page(), which simply calls put_page(). > > > This provides a

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-12 Thread John Hubbard
On 3/12/19 8:30 AM, Ira Weiny wrote: On Wed, Mar 06, 2019 at 03:54:55PM -0800, john.hubb...@gmail.com wrote: From: John Hubbard Introduces put_user_page(), which simply calls put_page(). This provides a way to update all get_user_pages*() callers, so that they call put_user_page(), instead of

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-12 Thread Ira Weiny
On Wed, Mar 06, 2019 at 03:54:55PM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > Introduces put_user_page(), which simply calls put_page(). > This provides a way to update all get_user_pages*() callers, > so that they call put_user_page(), instead of put_page(). So I've been

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread John Hubbard
On 3/8/19 9:57 AM, Jerome Glisse wrote: [snip] > Just a small comments below that would help my life :) > > Reviewed-by: Jérôme Glisse > Thanks for the review! >> --- >> include/linux/mm.h | 24 ++ >> mm/swap.c | 82 ++ > >

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread Jerome Glisse
On Wed, Mar 06, 2019 at 03:54:55PM -0800, john.hubb...@gmail.com wrote: > From: John Hubbard > > Introduces put_user_page(), which simply calls put_page(). > This provides a way to update all get_user_pages*() callers, > so that they call put_user_page(), instead of put_page(). > > Also

RE: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread Weiny, Ira
> Subject: Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder > versions > > On 3/7/19 6:58 PM, Christopher Lameter wrote: > > On Wed, 6 Mar 2019, john.hubb...@gmail.com wrote: > > > >> Dave Chinner's description of this is very clear: >

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-07 Thread John Hubbard
On 3/7/19 6:58 PM, Christopher Lameter wrote: > On Wed, 6 Mar 2019, john.hubb...@gmail.com wrote: > >> Dave Chinner's description of this is very clear: >> >> "The fundamental issue is that ->page_mkwrite must be called on every >> write access to a clean file backed page, not just the

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-07 Thread Christopher Lameter
On Wed, 6 Mar 2019, john.hubb...@gmail.com wrote: > Dave Chinner's description of this is very clear: > > "The fundamental issue is that ->page_mkwrite must be called on every > write access to a clean file backed page, not just the first one. > How long the GUP reference lasts is