Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Tonello wrote: > On Mon, Oct 12, 2015 at 11:16 AM, Clemens Ladisch wrote: >> Felipe Tonello wrote: >>> I believe that is the best way to implement. Create multiple requests >>> until the ALSA substreams buffer are empty and free the request on >>> completion. >> >> I believe a better way

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Clemens On Mon, Oct 12, 2015 at 11:16 AM, Clemens Ladisch wrote: > Felipe Tonello wrote: >> On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote: >>> Felipe Tonello wrote: } else if (ep == midi->in_ep) { - /* Our transmit completed. See if

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Tonello wrote: > On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote: >> Felipe Tonello wrote: >>> } else if (ep == midi->in_ep) { >>> - /* Our transmit completed. See if there's more to go. >>> - * f_midi_transmit eats req, don't

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Balbi, On Sun, Oct 11, 2015 at 8:08 PM, Clemens Ladisch wrote: > Felipe Balbi wrote: >> Clemens Ladisch writes: >>> Felipe Tonello wrote: req->actual == req->length means that there is no data left to enqueue, >>> >>> This condition is not checked in the patch. >>> so free the

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Clemens On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote: > Felipe Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, > > This condition is not checked in the patch. > >> so free the request. >> >> Signed-off-by: Felipe F. Tonello >> --- >>

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Balbi, On Sun, Oct 11, 2015 at 8:08 PM, Clemens Ladisch wrote: > Felipe Balbi wrote: >> Clemens Ladisch writes: >>> Felipe Tonello wrote: req->actual == req->length means that there is no data left to enqueue, >>> >>> This condition is not checked

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Clemens On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote: > Felipe Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, > > This condition is not checked in the patch. > >> so free the request. >> >> Signed-off-by: Felipe F.

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Tonello wrote: > On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote: >> Felipe Tonello wrote: >>> } else if (ep == midi->in_ep) { >>> - /* Our transmit completed. See if there's more to go. >>> - *

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Clemens On Mon, Oct 12, 2015 at 11:16 AM, Clemens Ladisch wrote: > Felipe Tonello wrote: >> On Fri, Oct 9, 2015 at 10:23 AM, Clemens Ladisch wrote: >>> Felipe Tonello wrote: } else if (ep == midi->in_ep) { -

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Tonello wrote: > On Mon, Oct 12, 2015 at 11:16 AM, Clemens Ladisch wrote: >> Felipe Tonello wrote: >>> I believe that is the best way to implement. Create multiple requests >>> until the ALSA substreams buffer are empty and free the request on >>> completion. >> >> I

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Balbi wrote: > Clemens Ladisch writes: >> Felipe Tonello wrote: >>> req->actual == req->length means that there is no data left to enqueue, >> >> This condition is not checked in the patch. >> >>> so free the request. >>> >>> Signed-off-by: Felipe F. Tonello >>> --- >>>

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Balbi wrote: > Clemens Ladisch writes: >> Felipe Tonello wrote: >>> req->actual == req->length means that there is no data left to enqueue, >> >> This condition is not checked in the patch. >> >>> so free the request. >>> >>> Signed-off-by: Felipe F. Tonello

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi, Clemens Ladisch writes: > Felipe Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, > > This condition is not checked in the patch. > >> so free the request. >> >> Signed-off-by: Felipe F. Tonello >> --- >> drivers/usb/gadget/function/f_midi.c | 5

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Tonello wrote: > req->actual == req->length means that there is no data left to enqueue, This condition is not checked in the patch. > so free the request. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Felipe Tonello wrote: > req->actual == req->length means that there is no data left to enqueue, This condition is not checked in the patch. > so free the request. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 5 ++--- > 1 file

Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi, Clemens Ladisch writes: > Felipe Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, > > This condition is not checked in the patch. > >> so free the request. >> >> Signed-off-by: Felipe F. Tonello >> --- >>