Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-21 Thread Thierry Reding
On Wed, Aug 20, 2014 at 02:29:17PM -0500, Dmitry Torokhov wrote: > On August 20, 2014 1:54:11 PM CDT, Doug Anderson > wrote: > >On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding > > wrote: > >> On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: > >>> The rk3288 has the ability to

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-21 Thread Thierry Reding
On Wed, Aug 20, 2014 at 02:29:17PM -0500, Dmitry Torokhov wrote: On August 20, 2014 1:54:11 PM CDT, Doug Anderson diand...@chromium.org wrote: On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: The

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Doug Anderson
Dmitry, On Wed, Aug 20, 2014 at 12:29 PM, Dmitry Torokhov wrote: > On August 20, 2014 1:54:11 PM CDT, Doug Anderson > wrote: >>On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding >> wrote: >>> On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: The rk3288 has the ability to invert

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Dmitry Torokhov
On August 20, 2014 1:54:11 PM CDT, Doug Anderson wrote: >On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding > wrote: >> On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: >>> The rk3288 has the ability to invert >>> + struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); >>> +

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Doug Anderson
Thierry, On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding wrote: > On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: >> The rk3288 has the ability to invert the polarity of the PWM. Let's >> enable that ability. >> >> To do this we increase the number of pwm_cells to 3 to allow

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Thierry Reding
On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: > The rk3288 has the ability to invert the polarity of the PWM. Let's > enable that ability. > > To do this we increase the number of pwm_cells to 3 to allow using the > PWM_POLARITY_INVERTED flag. Since the PWM driver on rk3288 is

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Thierry Reding
On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: The rk3288 has the ability to invert the polarity of the PWM. Let's enable that ability. To do this we increase the number of pwm_cells to 3 to allow using the PWM_POLARITY_INVERTED flag. Since the PWM driver on rk3288 is very

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Doug Anderson
Thierry, On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: The rk3288 has the ability to invert the polarity of the PWM. Let's enable that ability. To do this we increase the number of pwm_cells to

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Dmitry Torokhov
On August 20, 2014 1:54:11 PM CDT, Doug Anderson diand...@chromium.org wrote: On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: The rk3288 has the ability to invert + struct rockchip_pwm_chip *pc =

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-20 Thread Doug Anderson
Dmitry, On Wed, Aug 20, 2014 at 12:29 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On August 20, 2014 1:54:11 PM CDT, Doug Anderson diand...@chromium.org wrote: On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 09:07:54AM -0700,

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-19 Thread Caesar Wang
Hi Doug, I reviewed it, the change is need. Reviewed-on: https://github.com/rkchrome/kernel.git Reviewed-by: Caesar Wang 在 2014年08月20日 00:07, Doug Anderson 写道: The rk3288 has the ability to invert the polarity of the PWM. Let's enable that ability. To do this we increase the number of

Re: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

2014-08-19 Thread Caesar Wang
Hi Doug, I reviewed it, the change is need. Reviewed-on: https://github.com/rkchrome/kernel.git Reviewed-by: Caesar Wang caesar.w...@rock-chips.com 在 2014年08月20日 00:07, Doug Anderson 写道: The rk3288 has the ability to invert the polarity of the PWM. Let's enable that ability. To do this we