Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-08-09 Thread Eric W. Biederman
Oleg Nesterov writes: > On 07/26, Eric W. Biederman wrote: >> >> Are the earlier patches looking ok to you? > > I obviously like 1-15. > > "[PATCH 16/20] fork: Move and describe why the code examines PIDNS_ADDING" > is "interesting". I mean it is fine, but at the end of this series it doesn't >

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-08-09 Thread Eric W. Biederman
Oleg Nesterov writes: > On 07/26, Eric W. Biederman wrote: >> >> Are the earlier patches looking ok to you? > > I obviously like 1-15. > > "[PATCH 16/20] fork: Move and describe why the code examines PIDNS_ADDING" > is "interesting". I mean it is fine, but at the end of this series it doesn't >

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Oleg Nesterov
On 07/24, Eric W. Biederman wrote: > > Similarly the current code will also miss blocked > signals that are delivered to multiple process, as those signals will > not appear pending during fork. Well, I still think this needs a separate change and discussion... Let me repeat, I simply do not

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Oleg Nesterov
On 07/24, Eric W. Biederman wrote: > > Similarly the current code will also miss blocked > signals that are delivered to multiple process, as those signals will > not appear pending during fork. Well, I still think this needs a separate change and discussion... Let me repeat, I simply do not

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Oleg Nesterov
On 07/26, Eric W. Biederman wrote: > > Are the earlier patches looking ok to you? I obviously like 1-15. "[PATCH 16/20] fork: Move and describe why the code examines PIDNS_ADDING" is "interesting". I mean it is fine, but at the end of this series it doesn't matter what we check first,

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Oleg Nesterov
On 07/26, Eric W. Biederman wrote: > > Are the earlier patches looking ok to you? I obviously like 1-15. "[PATCH 16/20] fork: Move and describe why the code examines PIDNS_ADDING" is "interesting". I mean it is fine, but at the end of this series it doesn't matter what we check first,

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Eric W. Biederman
Oleg Nesterov writes: > On 07/24, Eric W. Biederman wrote: >> >> @@ -1979,6 +1983,8 @@ static __latent_entropy struct task_struct >> *copy_process( >> attach_pid(p, PIDTYPE_TGID); >> attach_pid(p, PIDTYPE_PGID); >> attach_pid(p,

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Eric W. Biederman
Oleg Nesterov writes: > On 07/24, Eric W. Biederman wrote: >> >> @@ -1979,6 +1983,8 @@ static __latent_entropy struct task_struct >> *copy_process( >> attach_pid(p, PIDTYPE_TGID); >> attach_pid(p, PIDTYPE_PGID); >> attach_pid(p,

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Oleg Nesterov
On 07/24, Eric W. Biederman wrote: > > @@ -1979,6 +1983,8 @@ static __latent_entropy struct task_struct > *copy_process( > attach_pid(p, PIDTYPE_TGID); > attach_pid(p, PIDTYPE_PGID); > attach_pid(p, PIDTYPE_SID); > +

Re: [PATCH v3 20/20] signal: Don't restart fork when signals come in.

2018-07-26 Thread Oleg Nesterov
On 07/24, Eric W. Biederman wrote: > > @@ -1979,6 +1983,8 @@ static __latent_entropy struct task_struct > *copy_process( > attach_pid(p, PIDTYPE_TGID); > attach_pid(p, PIDTYPE_PGID); > attach_pid(p, PIDTYPE_SID); > +