Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:48 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: >> In arch/x86/boot/header.S, we already use VO and ZO. >> So please keep on using them, and don't introduce "kernel proper" etc. > > So you're suggesting commit messages should

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: > In arch/x86/boot/header.S, we already use VO and ZO. > So please keep on using them, and don't introduce "kernel proper" etc. So you're suggesting commit messages should use variable names and prefixes from the code instead of being

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:21 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:17:01AM -0700, Yinghai Lu wrote: >> Make it not confusing. >> >> ZO: arch/x86/boot/compressed/vmlinux >> VO: vmlinux >> >> setup + ZO ==> bzImage. >> >> compressed kernel is just compressed VO. > > So the two end

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:17:01AM -0700, Yinghai Lu wrote: > Make it not confusing. > > ZO: arch/x86/boot/compressed/vmlinux > VO: vmlinux > > setup + ZO ==> bzImage. > > compressed kernel is just compressed VO. So the two end up being the "compressed kernel" and "kernel proper". And then

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:10 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:05:52AM -0700, Yinghai Lu wrote: >> We need to keep VO and ZO here... > > Why? Make it not confusing. ZO: arch/x86/boot/compressed/vmlinux VO: vmlinux setup + ZO ==> bzImage. compressed kernel is just

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:05:52AM -0700, Yinghai Lu wrote: > We need to keep VO and ZO here... Why? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 2:34 AM, Borislav Petkov wrote: > Final patch: > > --- > From: Yinghai Lu > Date: Sat, 7 Mar 2015 14:07:17 -0800 > Subject: [PATCH] x86/setup: Don't overlap vmlinux's brk with compressed > kernel's data We need to keep VO and ZO here... Should use ZO to replace

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
Final patch: --- From: Yinghai Lu Date: Sat, 7 Mar 2015 14:07:17 -0800 Subject: [PATCH] x86/setup: Don't overlap vmlinux's brk with compressed kernel's data We already do move the compressed kernel close to the end of the buffer. However, there's still overlapping beween kernel proper's

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
Final patch: --- From: Yinghai Lu ying...@kernel.org Date: Sat, 7 Mar 2015 14:07:17 -0800 Subject: [PATCH] x86/setup: Don't overlap vmlinux's brk with compressed kernel's data We already do move the compressed kernel close to the end of the buffer. However, there's still overlapping beween

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 2:34 AM, Borislav Petkov b...@suse.de wrote: Final patch: --- From: Yinghai Lu ying...@kernel.org Date: Sat, 7 Mar 2015 14:07:17 -0800 Subject: [PATCH] x86/setup: Don't overlap vmlinux's brk with compressed kernel's data We need to keep VO and ZO here... Should

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:10 AM, Borislav Petkov b...@suse.de wrote: On Tue, Mar 10, 2015 at 08:05:52AM -0700, Yinghai Lu wrote: We need to keep VO and ZO here... Why? Make it not confusing. ZO: arch/x86/boot/compressed/vmlinux VO: vmlinux setup + ZO == bzImage. compressed kernel is just

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:05:52AM -0700, Yinghai Lu wrote: We need to keep VO and ZO here... Why? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:17:01AM -0700, Yinghai Lu wrote: Make it not confusing. ZO: arch/x86/boot/compressed/vmlinux VO: vmlinux setup + ZO == bzImage. compressed kernel is just compressed VO. So the two end up being the compressed kernel and kernel proper. And then the subject

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: In arch/x86/boot/header.S, we already use VO and ZO. So please keep on using them, and don't introduce kernel proper etc. So you're suggesting commit messages should use variable names and prefixes from the code instead of being

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:21 AM, Borislav Petkov b...@suse.de wrote: On Tue, Mar 10, 2015 at 08:17:01AM -0700, Yinghai Lu wrote: Make it not confusing. ZO: arch/x86/boot/compressed/vmlinux VO: vmlinux setup + ZO == bzImage. compressed kernel is just compressed VO. So the two end up

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:48 AM, Borislav Petkov b...@suse.de wrote: On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: In arch/x86/boot/header.S, we already use VO and ZO. So please keep on using them, and don't introduce kernel proper etc. So you're suggesting commit messages