Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Mark Brown
On Thu, Oct 01, 2015 at 10:33:49AM -0500, Grygorii Strashko wrote: > So, in my opinion, the tps65217-regulator.c driver is really good > example of how it could be done. Yes, this should be a good example to refer to. signature.asc Description: Digital signature

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Andrew F. Davis
On 10/01/2015 10:33 AM, Grygorii Strashko wrote: Hi Andrew, On 09/30/2015 03:29 PM, Andrew F. Davis wrote: On 09/30/2015 12:28 PM, Mark Brown wrote: On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: On 09/29/2015 01:38 PM, Mark Brown wrote: Oh, ick. The binding has a

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Grygorii Strashko
Hi Andrew, On 09/30/2015 03:29 PM, Andrew F. Davis wrote: > On 09/30/2015 12:28 PM, Mark Brown wrote: >> On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: >>> On 09/29/2015 01:38 PM, Mark Brown wrote: >> Oh, ick. The binding has a compatible string in the individual

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Mark Brown
On Wed, Sep 30, 2015 at 06:32:14PM -0500, Andrew F. Davis wrote: > On 09/30/2015 05:20 PM, Mark Brown wrote: > >>This is already the case then, missing regulator nodes in old drivers will > >>not > >>get instantiated ether. And old drivers don't always store any more info > >>about >

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Mark Brown
On Wed, Sep 30, 2015 at 06:32:14PM -0500, Andrew F. Davis wrote: > On 09/30/2015 05:20 PM, Mark Brown wrote: > >>This is already the case then, missing regulator nodes in old drivers will > >>not > >>get instantiated ether. And old drivers don't always store any more info > >>about >

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Mark Brown
On Thu, Oct 01, 2015 at 10:33:49AM -0500, Grygorii Strashko wrote: > So, in my opinion, the tps65217-regulator.c driver is really good > example of how it could be done. Yes, this should be a good example to refer to. signature.asc Description: Digital signature

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Grygorii Strashko
Hi Andrew, On 09/30/2015 03:29 PM, Andrew F. Davis wrote: > On 09/30/2015 12:28 PM, Mark Brown wrote: >> On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: >>> On 09/29/2015 01:38 PM, Mark Brown wrote: >> Oh, ick. The binding has a compatible string in the individual

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-10-01 Thread Andrew F. Davis
On 10/01/2015 10:33 AM, Grygorii Strashko wrote: Hi Andrew, On 09/30/2015 03:29 PM, Andrew F. Davis wrote: On 09/30/2015 12:28 PM, Mark Brown wrote: On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: On 09/29/2015 01:38 PM, Mark Brown wrote: Oh, ick. The binding has a

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Andrew F. Davis
On 09/30/2015 05:20 PM, Mark Brown wrote: On Wed, Sep 30, 2015 at 03:29:30PM -0500, Andrew F. Davis wrote: On 09/30/2015 12:28 PM, Mark Brown wrote: No, you don't need to use regulator-compatible - that's deprecated. Just use the node names. Are we sure matching on node names is a good

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Mark Brown
On Wed, Sep 30, 2015 at 03:29:30PM -0500, Andrew F. Davis wrote: > On 09/30/2015 12:28 PM, Mark Brown wrote: > >No, you don't need to use regulator-compatible - that's deprecated. > >Just use the node names. > Are we sure matching on node names is a good idea? Most are just arbitrary > names

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Andrew F. Davis
On 09/30/2015 12:28 PM, Mark Brown wrote: On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: On 09/29/2015 01:38 PM, Mark Brown wrote: Oh, ick. The binding has a compatible string in the individual regulator bindings which is broken unless there really are lots of variants

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Mark Brown
On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: > On 09/29/2015 01:38 PM, Mark Brown wrote: > >Oh, ick. The binding has a compatible string in the individual > >regulator bindings which is broken unless there really are lots of > >variants being configured via DT (which is just

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Mark Brown
On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: > On 09/29/2015 01:38 PM, Mark Brown wrote: > >Oh, ick. The binding has a compatible string in the individual > >regulator bindings which is broken unless there really are lots of > >variants being configured via DT (which is just

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Andrew F. Davis
On 09/30/2015 12:28 PM, Mark Brown wrote: On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote: On 09/29/2015 01:38 PM, Mark Brown wrote: Oh, ick. The binding has a compatible string in the individual regulator bindings which is broken unless there really are lots of variants

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Mark Brown
On Wed, Sep 30, 2015 at 03:29:30PM -0500, Andrew F. Davis wrote: > On 09/30/2015 12:28 PM, Mark Brown wrote: > >No, you don't need to use regulator-compatible - that's deprecated. > >Just use the node names. > Are we sure matching on node names is a good idea? Most are just arbitrary > names

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-30 Thread Andrew F. Davis
On 09/30/2015 05:20 PM, Mark Brown wrote: On Wed, Sep 30, 2015 at 03:29:30PM -0500, Andrew F. Davis wrote: On 09/30/2015 12:28 PM, Mark Brown wrote: No, you don't need to use regulator-compatible - that's deprecated. Just use the node names. Are we sure matching on node names is a good

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Andrew F. Davis
On 09/29/2015 01:38 PM, Mark Brown wrote: On Tue, Sep 29, 2015 at 01:08:50PM -0500, Andrew F. Davis wrote: On 09/29/2015 10:13 AM, Mark Brown wrote: sure that will save me anything as my probe function is called with a DT match already, so no searching is needed. You've not understood

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Mark Brown
On Tue, Sep 29, 2015 at 01:08:50PM -0500, Andrew F. Davis wrote: > On 09/29/2015 10:13 AM, Mark Brown wrote: > >>sure that will save me anything as my probe function is called with a DT > >>match already, so no searching is needed. > >You've not understood what that change is replacing, the code

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Andrew F. Davis
On 09/29/2015 10:13 AM, Mark Brown wrote: On Fri, Sep 25, 2015 at 03:10:04PM -0500, Andrew F. Davis wrote: On 09/25/2015 01:05 PM, Mark Brown wrote: On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: + match = of_match_device(tps65912_regulator_of_match_table, >dev); +

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Mark Brown
On Fri, Sep 25, 2015 at 03:10:04PM -0500, Andrew F. Davis wrote: > On 09/25/2015 01:05 PM, Mark Brown wrote: > >On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: > >>+ match = of_match_device(tps65912_regulator_of_match_table, >dev); > >>+ if (!match) > >>+ return

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Mark Brown
On Fri, Sep 25, 2015 at 03:10:04PM -0500, Andrew F. Davis wrote: > On 09/25/2015 01:05 PM, Mark Brown wrote: > >On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: > >>+ match = of_match_device(tps65912_regulator_of_match_table, >dev); > >>+ if (!match) > >>+ return

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Andrew F. Davis
On 09/29/2015 10:13 AM, Mark Brown wrote: On Fri, Sep 25, 2015 at 03:10:04PM -0500, Andrew F. Davis wrote: On 09/25/2015 01:05 PM, Mark Brown wrote: On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: + match = of_match_device(tps65912_regulator_of_match_table, >dev); +

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Mark Brown
On Tue, Sep 29, 2015 at 01:08:50PM -0500, Andrew F. Davis wrote: > On 09/29/2015 10:13 AM, Mark Brown wrote: > >>sure that will save me anything as my probe function is called with a DT > >>match already, so no searching is needed. > >You've not understood what that change is replacing, the code

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-29 Thread Andrew F. Davis
On 09/29/2015 01:38 PM, Mark Brown wrote: On Tue, Sep 29, 2015 at 01:08:50PM -0500, Andrew F. Davis wrote: On 09/29/2015 10:13 AM, Mark Brown wrote: sure that will save me anything as my probe function is called with a DT match already, so no searching is needed. You've not understood

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-25 Thread Andrew F. Davis
On 09/25/2015 01:05 PM, Mark Brown wrote: On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: +static int tps65912_regulator_probe(struct platform_device *pdev) +{ + struct tps65912 *tps = dev_get_drvdata(pdev->dev.parent); + struct regulator_init_data *init_data; +

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-25 Thread Mark Brown
On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: > +static int tps65912_regulator_probe(struct platform_device *pdev) > +{ > + struct tps65912 *tps = dev_get_drvdata(pdev->dev.parent); > + struct regulator_init_data *init_data; > + const struct tps_info *template; > +

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-25 Thread Mark Brown
On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: > +static int tps65912_regulator_probe(struct platform_device *pdev) > +{ > + struct tps65912 *tps = dev_get_drvdata(pdev->dev.parent); > + struct regulator_init_data *init_data; > + const struct tps_info *template; > +

Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC

2015-09-25 Thread Andrew F. Davis
On 09/25/2015 01:05 PM, Mark Brown wrote: On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: +static int tps65912_regulator_probe(struct platform_device *pdev) +{ + struct tps65912 *tps = dev_get_drvdata(pdev->dev.parent); + struct regulator_init_data *init_data; +