Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-09-04 Thread Jarkko Sakkinen
On Tue, Sep 01, 2020 at 11:41:14AM -0500, Haitao Huang wrote: > On Thu, 16 Jul 2020 08:52:51 -0500, Jarkko Sakkinen > wrote: > > > Add an ioctl that performs ENCLS[ECREATE], which creates SGX Enclave > > Control Structure for the enclave. SECS contains attributes about the > > enclave that are

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-09-01 Thread Haitao Huang
On Thu, 16 Jul 2020 08:52:51 -0500, Jarkko Sakkinen wrote: Add an ioctl that performs ENCLS[ECREATE], which creates SGX Enclave Control Structure for the enclave. SECS contains attributes about the enclave that are used by the hardware and cannot be directly accessed by software, as SECS

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-08-28 Thread Jarkko Sakkinen
On Thu, Aug 27, 2020 at 04:24:50PM +0300, Jarkko Sakkinen wrote: > > > + * @arg: userspace pointer to a struct sgx_enclave_create instance > > > + * > > > + * Allocate kernel data structures for a new enclave and execute ECREATE > > > after > > > + * verifying the correctness of the provided

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-08-28 Thread Jarkko Sakkinen
On Thu, Aug 27, 2020 at 06:15:27PM +0200, Borislav Petkov wrote: > On Thu, Aug 27, 2020 at 04:24:36PM +0300, Jarkko Sakkinen wrote: > > I have not checked if this passes checkpatch.pl yet, but I would > > be surprised if that did not pass (obviously I'll check that). > > Right, when you're done

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-08-27 Thread Borislav Petkov
On Thu, Aug 27, 2020 at 04:24:36PM +0300, Jarkko Sakkinen wrote: > I have not checked if this passes checkpatch.pl yet, but I would > be surprised if that did not pass (obviously I'll check that). Right, when you're done with the patchset, just do checkpatch.pl -g ... on it before sending and

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-08-27 Thread Jarkko Sakkinen
On Wed, Aug 26, 2020 at 04:52:39PM +0200, Borislav Petkov wrote: > On Thu, Jul 16, 2020 at 04:52:51PM +0300, Jarkko Sakkinen wrote: > > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst > > b/Documentation/userspace-api/ioctl/ioctl-number.rst > > index 59472cd6a11d..35f713e3a267

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-08-26 Thread Borislav Petkov
On Thu, Jul 16, 2020 at 04:52:51PM +0300, Jarkko Sakkinen wrote: > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst > b/Documentation/userspace-api/ioctl/ioctl-number.rst > index 59472cd6a11d..35f713e3a267 100644 > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst > +++

Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-08-06 Thread Darren Kenny
On Thursday, 2020-07-16 at 16:52:51 +03, Jarkko Sakkinen wrote: > Add an ioctl that performs ENCLS[ECREATE], which creates SGX Enclave > Control Structure for the enclave. SECS contains attributes about the > enclave that are used by the hardware and cannot be directly accessed by > software, as