Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-21 Thread Kishon Vijay Abraham I
Hi, On Tuesday 07 May 2013 10:51 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 07 May 2013 06:13 AM, myungjoo.ham wrote: From: Graeme Gregory This is the driver for the USB comparator built into the palmas chip. It handles the various USB OTG events that can be generated by cable insertio

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-14 Thread Laxman Dewangan
On Tuesday 14 May 2013 03:24 PM, Graeme Gregory wrote: On Tue, May 14, 2013 at 02:48:53PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 07 May 2013 04:15 PM, Mark Brown wrote: On Tue, May 07, 2013 at 03:17:08PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 07 May 2013 01:28 PM, Mark Brown

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-14 Thread Graeme Gregory
On Tue, May 14, 2013 at 02:48:53PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 07 May 2013 04:15 PM, Mark Brown wrote: > >On Tue, May 07, 2013 at 03:17:08PM +0530, Kishon Vijay Abraham I wrote: > >>On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote: > > > The platform can provide it's own

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-14 Thread Kishon Vijay Abraham I
On Tuesday 07 May 2013 04:15 PM, Mark Brown wrote: On Tue, May 07, 2013 at 03:17:08PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote: The platform can provide it's own vbus control in which case this is not needed. So why is there no interaction with

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-07 Thread Mark Brown
On Tue, May 07, 2013 at 03:17:08PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote: > >>The platform can provide it's own vbus control in which case this is > >>not needed. > >So why is there no interaction with this external VBUS control and how > >does t

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-07 Thread Graeme Gregory
On 07/05/13 10:47, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote: >> On Tue, May 07, 2013 at 10:42:53AM +0530, Kishon Vijay Abraham I wrote: >>> On Monday 06 May 2013 08:10 PM, Mark Brown wrote: On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-07 Thread Kishon Vijay Abraham I
Hi, On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote: On Tue, May 07, 2013 at 10:42:53AM +0530, Kishon Vijay Abraham I wrote: On Monday 06 May 2013 08:10 PM, Mark Brown wrote: On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote: + if (palmas_usb->linkstat !=

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-07 Thread Kishon Vijay Abraham I
On Tuesday 07 May 2013 12:35 PM, Chanwoo Choi wrote: On 05/07/2013 03:57 PM, Chanwoo Choi wrote: diff --git a/include/linux/extcon/extcon_palmas.h b/include/linux/extcon/extcon_palmas.h new file mode 100644 index 000..a5119c9 --- /dev/null +++ b/include/linux/extcon/extcon_palmas.h @@ -0,0

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-07 Thread Mark Brown
On Tue, May 07, 2013 at 10:42:53AM +0530, Kishon Vijay Abraham I wrote: > On Monday 06 May 2013 08:10 PM, Mark Brown wrote: > >On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote: > > > >>+ if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) { > >>+ if

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-07 Thread Chanwoo Choi
On 05/07/2013 03:57 PM, Chanwoo Choi wrote: > diff --git a/include/linux/extcon/extcon_palmas.h > b/include/linux/extcon/extcon_palmas.h > new file mode 100644 > index 000..a5119c9 > --- /dev/null > +++ b/include/linux/extcon/extcon_palmas.h > @@ -0,0 +1,26 @@ > +/* > + * extcon_palmas.h - pal

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Chanwoo Choi
On 05/07/2013 03:25 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 07 May 2013 11:40 AM, Chanwoo Choi wrote: >> Hi Kishon, >> >> I add some opinion about this patch. >> >> On 05/06/2013 10:17 PM, Kishon Vijay Abraham I wrote: >>> From: Graeme Gregory >>> >>> This is the driver for the USB

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 07 May 2013 11:40 AM, Chanwoo Choi wrote: Hi Kishon, I add some opinion about this patch. On 05/06/2013 10:17 PM, Kishon Vijay Abraham I wrote: From: Graeme Gregory This is the driver for the USB comparator built into the palmas chip. It handles the various USB OTG events tha

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Chanwoo Choi
Hi Kishon, I add some opinion about this patch. On 05/06/2013 10:17 PM, Kishon Vijay Abraham I wrote: > From: Graeme Gregory > > This is the driver for the USB comparator built into the palmas chip. It > handles the various USB OTG events that can be generated by cable > insertion/removal. > > S

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 07 May 2013 06:13 AM, myungjoo.ham wrote: From: Graeme Gregory This is the driver for the USB comparator built into the palmas chip. It handles the various USB OTG events that can be generated by cable insertion/removal. Signed-off-by: Graeme Gregory Signed-off-by: Moiz Sonasa

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Kishon Vijay Abraham I
Hi, On Monday 06 May 2013 08:10 PM, Mark Brown wrote: On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote: + if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) { + if (palmas_usb->vbus_reg) { + ret = regulator

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Kishon Vijay Abraham I
Hi, On Monday 06 May 2013 07:56 PM, Laxman Dewangan wrote: On Monday 06 May 2013 06:47 PM, Kishon Vijay Abraham I wrote: + +static irqreturn_t palmas_vbus_wakeup_irq(int irq, void *_palmas_usb) Can we name the function to palams_vbus_irq_handler() for better understanding? Reserve the wakeup

RE: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread myungjoo.ham
> From: Graeme Gregory > > This is the driver for the USB comparator built into the palmas chip. It > handles the various USB OTG events that can be generated by cable > insertion/removal. > > Signed-off-by: Graeme Gregory > Signed-off-by: Moiz Sonasath > Signed-off-by: Ruchika Kharwar > Sign

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Mark Brown
On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote: > + if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) { > + if (palmas_usb->vbus_reg) { > + ret = regulator_enable(palmas_usb->vbus_reg); > +

Re: [PATCH v4] extcon: Palmas Extcon Driver

2013-05-06 Thread Laxman Dewangan
On Monday 06 May 2013 06:47 PM, Kishon Vijay Abraham I wrote: + +static irqreturn_t palmas_vbus_wakeup_irq(int irq, void *_palmas_usb) Can we name the function to palams_vbus_irq_handler() for better understanding? Reserve the wakeup word for the suspend-wakeups. + + +static irqreturn_t pa