RE: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Robin Gong
...@intel.com; gre...@linuxfoundation.org; jsl...@suse.com Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; dl-linux-imx ; linux-ser...@vger.kernel.org Subject: Re: [PATCH v4 0/7] add virt-dma support for imx-sdma Am Donnerstag, den 14.06.2018, 10:09

RE: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Robin Gong
...@intel.com; gre...@linuxfoundation.org; jsl...@suse.com Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; dl-linux-imx ; linux-ser...@vger.kernel.org Subject: Re: [PATCH v4 0/7] add virt-dma support for imx-sdma Am Donnerstag, den 14.06.2018, 10:09

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Lucas Stach
Am Donnerstag, den 14.06.2018, 10:09 + schrieb Robin Gong: > Hi Lucas, > Could you double check again? Still can reproduce lockdep > warning on UART if change > spin_lock_lockirqsave/spinlock_unlock_irqrestore to > spin_lock/spin_unlock in sdma_int_handler as you said without > patch7/7.

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Lucas Stach
Am Donnerstag, den 14.06.2018, 10:09 + schrieb Robin Gong: > Hi Lucas, > Could you double check again? Still can reproduce lockdep > warning on UART if change > spin_lock_lockirqsave/spinlock_unlock_irqrestore to > spin_lock/spin_unlock in sdma_int_handler as you said without > patch7/7.

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Robin Gong
Hi Lucas, Could you double check again? Still can reproduce lockdep warning on UART if change spin_lock_lockirqsave/spinlock_unlock_irqrestore to spin_lock/spin_unlock in sdma_int_handler as you said without patch7/7. Would you please ask below two more questions? 1. Does your uart case

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Robin Gong
Hi Lucas, Could you double check again? Still can reproduce lockdep warning on UART if change spin_lock_lockirqsave/spinlock_unlock_irqrestore to spin_lock/spin_unlock in sdma_int_handler as you said without patch7/7. Would you please ask below two more questions? 1. Does your uart case

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Lucas Stach
Hi Robin, I just gave this series a spin and it seems there is even more locking fun, see the lockdep output below. After taking a short look it seems this is caused by using the wrong spinlock variants in sdma_int_handler(), those should also use the _irqsave ones. When fixing this you might

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Lucas Stach
Hi Robin, I just gave this series a spin and it seems there is even more locking fun, see the lockdep output below. After taking a short look it seems this is caused by using the wrong spinlock variants in sdma_int_handler(), those should also use the _irqsave ones. When fixing this you might