Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

2016-12-15 Thread Andi Shyti
> > + /* rc_open will be called here */ > > + rc = input_register_device(dev->input_dev); > > + if (rc) > > + goto out_table; > > + > > + dev->input_dev->dev.parent = >dev; > > + memcpy(>input_dev->id, >input_id, sizeof(dev->input_id)); > > + dev->input_dev->phys =

Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

2016-12-15 Thread Andi Shyti
> > + /* rc_open will be called here */ > > + rc = input_register_device(dev->input_dev); > > + if (rc) > > + goto out_table; > > + > > + dev->input_dev->dev.parent = >dev; > > + memcpy(>input_dev->id, >input_id, sizeof(dev->input_id)); > > + dev->input_dev->phys =

Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

2016-12-15 Thread Sean Young
Hi Andi, This patch breaks all rc devices, none of them have input devices any more (see below). On Wed, Dec 14, 2016 at 11:00:26PM +0900, Andi Shyti wrote: > Move the input device allocation, map and protocol handling to > different functions. > > Signed-off-by: Andi Shyti

Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

2016-12-15 Thread Sean Young
Hi Andi, This patch breaks all rc devices, none of them have input devices any more (see below). On Wed, Dec 14, 2016 at 11:00:26PM +0900, Andi Shyti wrote: > Move the input device allocation, map and protocol handling to > different functions. > > Signed-off-by: Andi Shyti > Reviewed-by: Sean