Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-13 Thread Firoz Khan
Hi Paul, On Fri, 14 Dec 2018 at 01:45, Paul Burton wrote: > I've applied v5 but undone the change from __NR_64_* to __NR_N64_* > because it's part of the UAPI & a github code search showed that it's > actually used. > > Could you take a look at this branch & check that you're OK with it > before

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-13 Thread Paul Burton
Hi Firoz, On Thu, Dec 13, 2018 at 02:23:21PM +0530, Firoz Khan wrote: > > > So If you confirm I can send v5 without '64' to 'n64' conversion (not > > > just above > > > one, completely from this patch series). Or uou can take a call just > > > keep this macro - > > > _MIPS_SIM_ABI64 as it is and

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-13 Thread Firoz Khan
Hi Paul, On Thu, 13 Dec 2018 at 03:58, Paul Burton wrote: > > Hi Firoz, > > On Wed, Dec 12, 2018 at 10:04:47AM +0530, Firoz Khan wrote: > > > > Sure, I think '64' to 'n64' conversion must be remove it from this patch > > series.I can send v5 without '64' to 'n64' conversion. > > > > If we rename

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-12 Thread Paul Burton
Hi Firoz, On Wed, Dec 12, 2018 at 10:04:47AM +0530, Firoz Khan wrote: > > > Will this below change will help? > > > > > > #define _MIPS_SIM_ABI32 1 > > > #define _MIPS_SIM_NABI322 > > > #define _MIPS_SIM_ABI64 3 > > > +#define _MIPS_SIM_ABIN64

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-11 Thread Firoz Khan
Hi Paul, On Wed, 12 Dec 2018 at 00:29, Paul Burton wrote: > > Will this below change will help? > > > > #define _MIPS_SIM_ABI32 1 > > #define _MIPS_SIM_NABI322 > > #define _MIPS_SIM_ABI64 3 > > +#define _MIPS_SIM_ABIN64 _MIPS_SIM_ABI64 > > Hmm,

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-11 Thread Paul Burton
Hi Firoz, On Tue, Dec 11, 2018 at 02:15:19PM +0530, Firoz Khan wrote: > > > diff --git a/arch/mips/include/uapi/asm/sgidefs.h > > > b/arch/mips/include/uapi/asm/sgidefs.h > > > index 26143e3..0364eec 100644 > > > --- a/arch/mips/include/uapi/asm/sgidefs.h > > > +++

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-11 Thread Maciej W. Rozycki
Hi Paul, > > My feeling has been n32 was invented at SGI as an afterthought, hence the > > choice of having ABI32 or ABI64 defined for the 32-bit (now o32) and the > > 64-bit (now n64) ABI respectively was reasonable. > > I'd agree if _MIPS_SIM were defined as _ABI32 for o32, but: > > $

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-11 Thread Firoz Khan
Hi Paul, On Tue, 11 Dec 2018 at 01:21, Paul Burton wrote: > > Hi Firoz, > > On Thu, Dec 06, 2018 at 10:48:24AM +0530, Firoz Khan wrote: > > diff --git a/arch/mips/include/uapi/asm/sgidefs.h > > b/arch/mips/include/uapi/asm/sgidefs.h > > index 26143e3..0364eec 100644 > > ---

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-10 Thread Paul Burton
Hi Maciej, On Mon, Dec 10, 2018 at 11:32:46PM +, Maciej W. Rozycki wrote: > On Mon, 10 Dec 2018, Paul Burton wrote: > > > And I realise that undoing that but keeping n64 in our own filenames & > > macros is another type of inconsistency, but something imperfect is > > unavoidable at this

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-10 Thread Maciej W. Rozycki
On Mon, 10 Dec 2018, Paul Burton wrote: > And I realise that undoing that but keeping n64 in our own filenames & > macros is another type of inconsistency, but something imperfect is > unavoidable at this point given that the engineers way back when decided > to use "ABI64" for n64. My feeling

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-10 Thread Paul Burton
Hi Firoz, On Thu, Dec 06, 2018 at 10:48:24AM +0530, Firoz Khan wrote: > diff --git a/arch/mips/include/uapi/asm/sgidefs.h > b/arch/mips/include/uapi/asm/sgidefs.h > index 26143e3..0364eec 100644 > --- a/arch/mips/include/uapi/asm/sgidefs.h > +++ b/arch/mips/include/uapi/asm/sgidefs.h > @@ -40,6